fix: update no-dom-import rule to report the right module name

PrashantAshok · PrashantAshok · commit 387cda274883 · 2022-05-04T14:18:22.000-07:00
diff --git a/lib/rules/no-dom-import.ts b/lib/rules/no-dom-import.ts
@@ -47,7 +47,11 @@ export default createTestingLibraryRule<Options, MessageIds>({
       moduleName: string
     ) {
       if (framework) {
-        const correctModuleName = moduleName.replace('dom', framework);
+        // marko TL is called @marko/testing-library
+        const correctModuleName =
+          framework === 'marko'
+            ? moduleName.replace('dom-', `@${framework}/`)
+            : moduleName.replace('dom', framework);
         context.report({
           node,
           messageId: 'noDomImportFramework',
diff --git a/tests/lib/rules/no-dom-import.test.ts b/tests/lib/rules/no-dom-import.test.ts
@@ -74,11 +74,11 @@ ruleTester.run(RULE_NAME, rule, {
         {
           messageId: 'noDomImportFramework',
           data: {
-            module: 'marko-testing-library',
+            module: '@marko/testing-library',
           },
         },
       ],
-      output: `import { fireEvent } from "marko-testing-library"`,
+      output: `import { fireEvent } from "@marko/testing-library"`,
     },
     // Single quote or double quotes should not be replaced
     {

Original file line number	Diff line number	Diff line change
`@@ -74,11 +74,11 @@ ruleTester.run(RULE_NAME, rule, {`
`74`	`74`	`{`
`75`	`75`	`messageId: 'noDomImportFramework',`
`76`	`76`	`data: {`
`77`		`- module: 'marko-testing-library',`
	`77`	`+ module: '@marko/testing-library',`
`78`	`78`	`},`
`79`	`79`	`},`
`80`	`80`	`],`
`81`		- output: `import { fireEvent } from "marko-testing-library"`,
	`81`	+ output: `import { fireEvent } from "@marko/testing-library"`,
`82`	`82`	`},`
`83`	`83`	`// Single quote or double quotes should not be replaced`
`84`	`84`	`{`