Skip to content

Commit f634bfd

Browse files
PrashantAshokPrashantAshok
committed
test: render-result-naming-convention
1 parent cc11827 commit f634bfd

File tree

1 file changed

+58
-28
lines changed

1 file changed

+58
-28
lines changed

‎tests/lib/rules/render-result-naming-convention.test.ts

+58-28
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,17 @@ ruleTester.run(RULE_NAME, rule, {
1010
{
1111
code: `
1212
import { render } from '@testing-library/react';
13-
13+
14+
test('should not report straight destructured render result', () => {
15+
const { rerender, getByText } = render(<SomeComponent />);
16+
const button = getByText('some button');
17+
});
18+
`,
19+
},
20+
{
21+
code: `
22+
import { render } from '@marko/testing-library';
23+
1424
test('should not report straight destructured render result', () => {
1525
const { rerender, getByText } = render(<SomeComponent />);
1626
const button = getByText('some button');
@@ -20,7 +30,7 @@ ruleTester.run(RULE_NAME, rule, {
2030
{
2131
code: `
2232
import * as RTL from '@testing-library/react';
23-
33+
2434
test('should not report straight destructured render result from wildcard import', () => {
2535
const { rerender, getByText } = RTL.render(<SomeComponent />);
2636
const button = getByText('some button');
@@ -30,7 +40,7 @@ ruleTester.run(RULE_NAME, rule, {
3040
{
3141
code: `
3242
import { render } from '@testing-library/react';
33-
43+
3444
test('should not report straight render result called "utils"', async () => {
3545
const utils = render(<SomeComponent />);
3646
await utils.findByRole('button');
@@ -40,7 +50,7 @@ ruleTester.run(RULE_NAME, rule, {
4050
{
4151
code: `
4252
import { render } from '@testing-library/react';
43-
53+
4454
test('should not report straight render result called "view"', async () => {
4555
const view = render(<SomeComponent />);
4656
await view.findByRole('button');
@@ -50,9 +60,9 @@ ruleTester.run(RULE_NAME, rule, {
5060
{
5161
code: `
5262
import { render } from '@testing-library/react';
53-
63+
5464
const setup = () => render(<SomeComponent />);
55-
65+
5666
test('should not report destructured render result from wrapping function', () => {
5767
const { rerender, getByText } = setup();
5868
const button = getByText('some button');
@@ -62,9 +72,9 @@ ruleTester.run(RULE_NAME, rule, {
6272
{
6373
code: `
6474
import { render } from '@testing-library/react';
65-
75+
6676
const setup = () => render(<SomeComponent />);
67-
77+
6878
test('should not report render result called "utils" from wrapping function', async () => {
6979
const utils = setup();
7080
await utils.findByRole('button');
@@ -74,9 +84,9 @@ ruleTester.run(RULE_NAME, rule, {
7484
{
7585
code: `
7686
import { render } from '@testing-library/react';
77-
87+
7888
const setup = () => render(<SomeComponent />);
79-
89+
8090
test('should not report render result called "view" from wrapping function', async () => {
8191
const view = setup();
8292
await view.findByRole('button');
@@ -87,7 +97,7 @@ ruleTester.run(RULE_NAME, rule, {
8797
code: `
8898
import { screen } from '@testing-library/react';
8999
import { customRender } from 'test-utils';
90-
100+
91101
test('should not report straight destructured render result from custom render', () => {
92102
const { unmount } = customRender(<SomeComponent />);
93103
const button = screen.getByText('some button');
@@ -98,7 +108,7 @@ ruleTester.run(RULE_NAME, rule, {
98108
{
99109
code: `
100110
import { customRender } from 'test-utils';
101-
111+
102112
test('should not report render result called "view" from custom render', async () => {
103113
const view = customRender();
104114
await view.findByRole('button');
@@ -109,7 +119,7 @@ ruleTester.run(RULE_NAME, rule, {
109119
{
110120
code: `
111121
import { customRender } from 'test-utils';
112-
122+
113123
test('should not report render result called "utils" from custom render', async () => {
114124
const utils = customRender();
115125
await utils.findByRole('button');
@@ -120,7 +130,7 @@ ruleTester.run(RULE_NAME, rule, {
120130
{
121131
code: `
122132
import { render } from '@testing-library/react';
123-
133+
124134
const setup = () => {
125135
// this one must have a valid name
126136
const view = render(<SomeComponent />);
@@ -139,7 +149,7 @@ ruleTester.run(RULE_NAME, rule, {
139149
code: `
140150
import { render as testingLibraryRender } from '@testing-library/react';
141151
import { render } from '@somewhere/else'
142-
152+
143153
const setup = () => render(<SomeComponent />);
144154
145155
test('aggressive reporting disabled - should not report nested render not related to TL', () => {
@@ -156,7 +166,7 @@ ruleTester.run(RULE_NAME, rule, {
156166
code: `
157167
import { customRender as myRender } from 'test-utils';
158168
import { customRender } from 'non-related'
159-
169+
160170
const setup = () => {
161171
return customRender(<SomeComponent />);
162172
};
@@ -177,7 +187,7 @@ ruleTester.run(RULE_NAME, rule, {
177187
code: `
178188
import { customRender as myRender } from 'test-utils';
179189
import { render } from 'non-related'
180-
190+
181191
const setup = () => {
182192
return render(<SomeComponent />);
183193
};
@@ -198,7 +208,27 @@ ruleTester.run(RULE_NAME, rule, {
198208
{
199209
code: `
200210
import { render } from '@testing-library/react';
201-
211+
212+
test('should report straight render result called "wrapper"', async () => {
213+
const wrapper = render(<SomeComponent />);
214+
await wrapper.findByRole('button');
215+
});
216+
`,
217+
errors: [
218+
{
219+
messageId: 'renderResultNamingConvention',
220+
data: {
221+
renderResultName: 'wrapper',
222+
},
223+
line: 5,
224+
column: 17,
225+
},
226+
],
227+
},
228+
{
229+
code: `
230+
import { render } from '@marko/testing-library';
231+
202232
test('should report straight render result called "wrapper"', async () => {
203233
const wrapper = render(<SomeComponent />);
204234
await wrapper.findByRole('button');
@@ -218,7 +248,7 @@ ruleTester.run(RULE_NAME, rule, {
218248
{
219249
code: `
220250
import * as RTL from '@testing-library/react';
221-
251+
222252
test('should report straight render result called "wrapper" from wildcard import', () => {
223253
const wrapper = RTL.render(<SomeComponent />);
224254
const button = wrapper.getByText('some button');
@@ -238,7 +268,7 @@ ruleTester.run(RULE_NAME, rule, {
238268
{
239269
code: `
240270
import { render } from '@testing-library/react';
241-
271+
242272
test('should report straight render result called "component"', async () => {
243273
const component = render(<SomeComponent />);
244274
await component.findByRole('button');
@@ -258,7 +288,7 @@ ruleTester.run(RULE_NAME, rule, {
258288
{
259289
code: `
260290
import { render } from '@testing-library/react';
261-
291+
262292
test('should report straight render result called "notValidName"', async () => {
263293
const notValidName = render(<SomeComponent />);
264294
await notValidName.findByRole('button');
@@ -275,7 +305,7 @@ ruleTester.run(RULE_NAME, rule, {
275305
{
276306
code: `
277307
import { render as testingLibraryRender } from '@testing-library/react';
278-
308+
279309
test('should report renamed render result called "wrapper"', async () => {
280310
const wrapper = testingLibraryRender(<SomeComponent />);
281311
await wrapper.findByRole('button');
@@ -295,7 +325,7 @@ ruleTester.run(RULE_NAME, rule, {
295325
{
296326
code: `
297327
import { render } from '@testing-library/react';
298-
328+
299329
const setup = () => {
300330
// this one must have a valid name
301331
const wrapper = render(<SomeComponent />);
@@ -323,7 +353,7 @@ ruleTester.run(RULE_NAME, rule, {
323353
settings: { 'testing-library/utils-module': 'test-utils' },
324354
code: `
325355
import { render } from '@testing-library/react';
326-
356+
327357
const setup = () => render(<SomeComponent />);
328358
329359
test('aggressive reporting disabled - should report nested render from TL package', () => {
@@ -346,7 +376,7 @@ ruleTester.run(RULE_NAME, rule, {
346376
settings: { 'testing-library/utils-module': 'test-utils' },
347377
code: `
348378
import { render } from 'test-utils';
349-
379+
350380
function setup() {
351381
doSomethingElse();
352382
return render(<SomeComponent />)
@@ -454,7 +484,7 @@ ruleTester.run(RULE_NAME, rule, {
454484
{
455485
code: `
456486
import { render as testingLibraryRender } from '@testing-library/react';
457-
487+
458488
const setup = () => {
459489
return testingLibraryRender(<SomeComponent />);
460490
};
@@ -479,7 +509,7 @@ ruleTester.run(RULE_NAME, rule, {
479509
settings: { 'testing-library/utils-module': 'test-utils' },
480510
code: `
481511
import { render as testingLibraryRender } from '@testing-library/react';
482-
512+
483513
const setup = () => {
484514
return testingLibraryRender(<SomeComponent />);
485515
};
@@ -509,7 +539,7 @@ ruleTester.run(RULE_NAME, rule, {
509539
},
510540
code: `
511541
import { customRender as myRender } from 'test-utils';
512-
542+
513543
const setup = () => {
514544
return myRender(<SomeComponent />);
515545
};

0 commit comments

Comments
 (0)