Skip to content

Autogenerate recommended config #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,7 @@ Then configure the rules you want to use under the rules section.

```json
{
"rules": {
"jest-dom/prefer-checked": "error",
"jest-dom/prefer-enabled-disabled": "error",
"jest-dom/prefer-required": "error"
}
"rules": {}
}
```

Expand Down
14 changes: 9 additions & 5 deletions lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,17 @@ let requireIndex = require('requireindex');
// import all rules in lib/rules
module.exports.rules = requireIndex(__dirname + '/rules');

module.exports.generateRecommendedConfig = rules => {
return Object.entries(rules).reduce(
(memo, [name, rule]) =>
rule.meta.docs.recommended ? { ...memo, [name]: 'error' } : memo,
{}
);
};

module.exports.configs = {
recommended: {
plugins: ['jest-dom'],
rules: {
'jest-dom/prefer-checked': 'error',
'jest-dom/prefer-enabled-disabled': 'error',
'jest-dom/prefer-required': 'error',
},
rules: module.exports.generateRecommendedConfig(module.exports.rules),
},
};
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"generate-readme-table": "node build/generate-readme-table.js"
},
"dependencies": {
"requireindex": "~1.1.0"
"requireindex": "~1.2.0"
},
"devDependencies": {
"eslint": "^6.6.0",
Expand All @@ -30,4 +30,4 @@
"node": ">=0.10.0"
},
"license": "ISC"
}
}
41 changes: 40 additions & 1 deletion tests/__snapshots__/index.test.js.snap
Original file line number Diff line number Diff line change
@@ -1,3 +1,42 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`should have all the rules 1`] = `Object {}`;
exports[`should have all the rules 1`] = `
Object {
"prefer-checked": Object {
"create": [Function],
"meta": Object {
"docs": Object {
"category": "jest-dom",
"description": "prefer toBeChecked over checking attributes",
"recommended": true,
"url": "prefer-checked",
},
"fixable": "code",
},
},
"prefer-enabled-disabled": Object {
"create": [Function],
"meta": Object {
"docs": Object {
"category": "jest-dom",
"description": "prefer toBeDisabled or toBeEnabled over checking attributes",
"recommended": true,
"url": "prefer-enabled-disabled",
},
"fixable": "code",
},
},
"prefer-required": Object {
"create": [Function],
"meta": Object {
"docs": Object {
"category": "jest-dom",
"description": "prefer toBeRequired over checking properties",
"recommended": true,
"url": "prefer-required",
},
"fixable": "code",
},
},
}
`;
11 changes: 10 additions & 1 deletion tests/index.test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
const { rules } = require('../lib/index');
const { rules, generateRecommendedConfig, configs } = require('../lib/index');

it('should have all the rules', () => {
expect(rules).toMatchSnapshot();
});

it('should have a recommended config with recommended rules', () => {
expect(
generateRecommendedConfig({
good: { meta: { docs: { recommended: true } } },
bad: { meta: { docs: { recommended: false } } },
})
).toEqual({ good: 'error' });
});