Skip to content

feat: remove bindElementToQueries #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2020

Conversation

NMinhNguyen
Copy link
Contributor

BREAKING CHANGE: Use getQueriesForElement or within instead.

What: Remove bindElementToQueries in favour of getQueriesForElement and within.

Why: #471 (comment)

How: Remove bindElementToQueries export

Checklist:

BREAKING CHANGE: Use `getQueriesForElement` or `within` instead.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aece412:

Sandbox Source
keen-http-jb1hg Configuration

@codecov
Copy link

codecov bot commented Mar 8, 2020

Codecov Report

Merging #472 into beta will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           beta   #472   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        22     22           
  Lines       421    421           
  Branches    101    101           
===================================
  Hits        421    421

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a45bda...aece412. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 👍👍 thanks!

@kentcdodds kentcdodds merged commit 12b2cf7 into testing-library:beta Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants