feat: add semantic html elements implicit role support to queryByRole… #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/getByRole selectors (testing-library#262) * Add aria-query library as a dependency * Extend queryByRole to use aria-query ARIA roles to identify semantic HTML elements
kentcdodds
approved these changes
Jun 8, 2019
|
Seriously. Thank you! |
|
@all-contributors please add @szabototo89 for code and tests |
|
I've put up a pull request to add @szabototo89! 🎉 |
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
I couldn't find your twitter username, but here's a thank-you tweet as well: https://twitter.com/kentcdodds/status/1137446728724930565 |
|
I'm happy to help! :) Thank you very much! My twitter name is @szabototo (https://twitter.com/szabototo) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…/getByRole selectors (#262)
Add aria-query library as a dependency
Extend queryByRole to use aria-query ARIA roles to identify semantic HTML elements
What:
queryAllByRolefunction has been extended to find semantic HTML elements by role. So users don't need to anymore explicitly specifyroleattributes to find elements.Why: It makes dom-testing-library more convenient to use.
How:
queryAllByRolefunction has been extended to find HTML elements based on HTML element names and attributes.aria-querylibrary has been used for get elements-role mapping.Checklist:
docs site