Skip to content

Update package.json #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rajagopalpalani
Copy link

To support latest react version

What:

Why:

How:

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • TypeScript definitions updated
  • Ready to be merged

To support latest react version
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2bee54f:

Sandbox Source
react-testing-library-examples Configuration

@MatanBobi
Copy link
Member

@rajagopalpalani Can you please provide more context into why this change is needed?

@lukeapage
Copy link

I just coincidentally came across this because typescript performance analyse pointed this out as a duplicate package in node_modules. Its to upgrade so they can be deduped.

@MatanBobi
Copy link
Member

MatanBobi commented Apr 17, 2024

What's the reason it's duplicated? Is that only for your package? I don't see a reason for this to be duplicated in our repo. To solve this on your end, you can use yarn resolutions or npm overrides

@lukeapage
Copy link

We depend on testing library and jest and jest is upgraded and testing library is not.

I have no idea if this pr is correct or not but why wouldn’t you want to regularly update to the latest version ?

@MatanBobi
Copy link
Member

Since we're following semver, we need to understand if this should cause a major upgrade in our library which we just made. I'm not sure and I currently don't have the time to invest in understanding what are the changes in pretty-format. If we're exporting some of it's functionalities, this might break our API.

@rajagopalpalani
Copy link
Author

I thought version was an issue. I am closing this MR. Its an issue from our end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants