Skip to content

refactor: Leverage early return #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2022
Merged

refactor: Leverage early return #1102

merged 2 commits into from
Feb 3, 2022

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented Feb 3, 2022

This simple PR leverages the early return pattern (which is already heavily used across the codebase).

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 02ac966:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #1102 (02ac966) into main (7f5d421) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          956       955    -1     
  Branches       315       311    -4     
=========================================
- Hits           956       955    -1     
Flag Coverage Δ
node-12 100.00% <100.00%> (ø)
node-14 100.00% <100.00%> (ø)
node-16.9.1 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/matches.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f5d421...02ac966. Read the comment docs.

Copy link
Member

@MatanBobi MatanBobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@afontcu afontcu merged commit 30bd614 into main Feb 3, 2022
@afontcu afontcu deleted the refactor-early-return branch February 3, 2022 13:14
@github-actions
Copy link

🎉 This PR is included in version 8.11.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants