Skip to content

Move typings to DefinitelyTyped #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kentcdodds opened this issue Aug 15, 2019 · 5 comments
Closed

Move typings to DefinitelyTyped #68

kentcdodds opened this issue Aug 15, 2019 · 5 comments
Labels
help wanted Extra attention is needed released

Comments

@kentcdodds
Copy link
Member

Several of the Testing Library repositories are doing this in an effort to improve the type definitions (it's recommended by the TypeScript team to do this if the source isn't written with TypeScript).

Anyone wanna take that on? Can reference this PR: testing-library/react-testing-library#437
@kentcdodds kentcdodds added the help wanted Extra attention is needed label Aug 15, 2019
@simjes
Copy link
Contributor

simjes commented Aug 15, 2019

I'd like to work on this

@kentcdodds
Copy link
Member Author

That would be fantastic! Please do!

@simjes simjes mentioned this issue Aug 16, 2019
Merged
10 tasks
@simjes
Copy link
Contributor

simjes commented Aug 16, 2019 •
edited
Loading

Waiting for feedback on PR at DefinitelyTyped, will continue this when it's merged

simjes added a commit to simjes/cypress-testing-library that referenced this issue Aug 17, 2019
@simjes
Move typings to DefinitelyTyped, Close testing-library#68
8e9d331
simjes added a commit to simjes/cypress-testing-library that referenced this issue Aug 17, 2019
@simjes
Move typings to DefinitelyTyped, Close testing-library#68
79b1d42
simjes added a commit to simjes/cypress-testing-library that referenced this issue Aug 17, 2019
@simjes
Move typings to DefinitelyTyped, Close testing-library#68
520cc9d
@simjes simjes mentioned this issue Aug 17, 2019
Merged
3 tasks
@kentcdodds
Copy link
Member Author

🎉 This issue has been resolved in version 4.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@YOU54F
Copy link

YOU54F commented Aug 21, 2019

Good work on this team,

Using semver, this release probably shouldn't have been a bug fix, as it breaks for users who consume the typings from this project and use carets in their package.json. I would have expected it to be a minor version release.

@NicholasBoll NicholasBoll mentioned this issue Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kentcdodds @simjes @YOU54F