Fix karma example jasmine matchers #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the changes made in this PR are sufficient. |
|
@timdeschryver I think OK if you think it's OK. 👍 |
timdeschryver
approved these changes
Jun 1, 2022
|
Thanks @lacolaco ! |
|
🎉 This PR is included in version 12.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is just a prototype for an explanation.
Currently,
example-app-karmais not working well as an integration test case becausejasmine-matchers.tsis not loaded bytest.ts.I've tried to run tests correctly by renaming it to
jasmine-matchers.spec.ts, but it failed.The reason is the wrong setup to install custom matchers to Jasmine. I fixed it and now the specs are all green.
I think there are some ways to solve this problem.
testing-library/jasmine-dom@timdeschryver How do you think?