Skip to content

chore: set protocol for npm to https #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MatanBobi
Copy link
Member

Following testing-library/react-testing-library#975

Why:

npm notice Beginning October 4, 2021, all connections to the npm registry - including for package installation - must use TLS 1.2 or higher. You are currently using plaintext http to connect.

Checklist:

  • Ready to be merged

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timdeschryver timdeschryver merged commit e0365fd into testing-library:main Oct 16, 2021
@timdeschryver
Copy link
Member

@all-contributors please add @MatanBobi for maintenance

@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @MatanBobi! 🎉

@github-actions
Copy link

🎉 This PR is included in version 10.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants