docs: add FAQ section #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, @portothree... it will certainly help :) |
rafaelss95
reviewed
Nov 10, 2020
| @@ -218,6 +219,11 @@ Contributions of any kind welcome! | |||
| [**Read The Docs**](https://testing-library.com/angular) | | |||
| [Edit the docs](https://github.com/testing-library/testing-library-docs) | |||
|
|
|||
| ## FAQ | |||
|
|
|||
| ##### I am using Reactive Forms and the `jest-dom` matcher `toHaveFormValues` always returns an empty object or there are missing fields. Why? | |||
There was a problem hiding this comment.
How about mentioning the directive proposed by @timdeschryver?
There was a problem hiding this comment.
I'm going to merge this one already, because it helps other devs.
Feel free to update this and mention the directive @rafaelss95 .
timdeschryver
approved these changes
Nov 10, 2020
|
Thanks @portothree ! @all-contributors please add @portothree for docs |
|
I've put up a pull request to add @portothree! 🎉 |
|
🎉 This PR is included in version 10.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was reading #162 and also found useful to have a FAQ section and have included the question mentioned in the issue as the first one. Hope this helps!