Skip to content

Add ESLint with the eslint-plugin-testing-library and adjust examples #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
the-ult opened this issue Apr 12, 2021 · 5 comments · Fixed by #201
Closed

Add ESLint with the eslint-plugin-testing-library and adjust examples #198

the-ult opened this issue Apr 12, 2021 · 5 comments · Fixed by #201
Labels

Comments

@the-ult
Copy link
Contributor

the-ult commented Apr 12, 2021

Context

To provide the 'best' examples possible it would be good to use the eslint-plugin-testing-library and eslint-plugin-jest-dom

And update the examples with the best practices.

@see common-mistakes-with-testing-library

@timdeschryver
Copy link
Member

Thanks @the-ult , I was waiting on a migration schematic and NX recently released one.
If you want, feel free to migrate the linter.

@the-ult
Copy link
Contributor Author

the-ult commented Apr 12, 2021

Hi @timdeschryver ,

I will try to find some time this week to add a PR.
Would you prefer 2 different PR's or can I combine them?

  • replace TSLint with ESLint
  • add testing-library eslint rules

@timdeschryver
Copy link
Member

@the-ult yea, I think that would be ideal!

@the-ult
Copy link
Contributor Author

the-ult commented Apr 13, 2021

Hey @timdeschryver I added the pull-request for the migration part
Could you take look? And check/test it where needed?

@github-actions
Copy link

🎉 This issue has been resolved in version 10.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants