Skip to content

resource_tc_mysql_instance patch #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2020
Merged

resource_tc_mysql_instance patch #464

merged 4 commits into from
Jul 7, 2020

Conversation

piggona
Copy link
Contributor

@piggona piggona commented Jul 7, 2020

Rewrite tag creation part in resource mysql_instance with tencentcloud_tag service package

@ghost ghost added the size/M label Jul 7, 2020
@Sherlock-Holo
Copy link
Contributor

附上 mysql 相关的单元测试结果,类似 https://github.com/terraform-providers/terraform-provider-tencentcloud/pull/449#issuecomment-644152764 这样的是不是更好

@piggona
Copy link
Contributor Author

piggona commented Jul 7, 2020

$ go test -v ./tencentcloud -test.run TestAccTencentCloudMysqlMasterInstance_basic_and_update
=== RUN TestAccTencentCloudMysqlMasterInstance_basic_and_update
--- PASS: TestAccTencentCloudMysqlMasterInstance_basic_and_update (571.60s)
PASS
ok github.com/terraform-providers/terraform-provider-tencentcloud/tencentcloud 571.654s

@Sherlock-Holo
Copy link
Contributor

changelog 是不是没写

@likexian likexian merged commit 0527358 into tencentcloudstack:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants