Skip to content

redis type_id,redis_shard_num,redis_replicas_num supports. #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2020

Conversation

Himer
Copy link
Contributor

@Himer Himer commented May 21, 2020

ENHANCEMENTS:
Resource: tencentcloud_redis_instance add new argument type_id,redis_shard_num,redis_replicas_num
Data Source: tencentcloud_redis_instances add new argument type_id,redis_shard_num,redis_replicas_num
Data Source: tencentcloud_redis_zone_config add output argument type_id and new output argument type_id,redis_shard_nums,redis_replicas_nums

DEPRECATED:

  • Resource: tencentcloud_redis_instance: optional argument type is no longer supported, replace by type_id.
  • Data Source: tencentcloud_redis_instances: output argument type is no longer supported, replace by type_id
  • Data Source: tencentcloud_redis_zone_config: output argument type is no longer supported, replace by type_id

=== RUN TestAccTencentCloudRedisInstancesDataSource
--- PASS: TestAccTencentCloudRedisInstancesDataSource (49.39s)
=== RUN TestAccTencentCloudRedisInstance
--- PASS: TestAccTencentCloudRedisInstance (70.04s)
=== RUN TestAccTencentCloudRedisBackupConfig
--- PASS: TestAccTencentCloudRedisBackupConfig (49.01s)
=== RUN TestAccDataSourceRedisZoneConfig_basic
--- PASS: TestAccDataSourceRedisZoneConfig_basic (1.67s)

#410

"type": {
Type: schema.TypeString,
ForceNew: true,
Optional: true,
Default: REDIS_NAMES[REDIS_VERSION_MASTER_SLAVE_REDIS],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删除default可能造成以前老的配置不兼容

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处无法完美兼容 除非测试redis才不写type

@likexian likexian merged commit 48fac55 into tencentcloudstack:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants