Skip to content

fix(teo): [123456789] tencentcloud_teo_l7_acc_rule optimize update module code #3234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(teo): [123456789] tencentcloud_teo_l7_acc_rule optimize update module code #3234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b4cce7
add
SevenEarth Mar 21, 2025
207a000
add
SevenEarth Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/3234.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/tencentcloud_teo_l7_acc_rule: optimize update module code
```
164 changes: 138 additions & 26 deletions tencentcloud/services/teo/resource_tc_teo_l7_acc_rule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// Code generated by iacg; DO NOT EDIT.
package teo

import (
Expand Down Expand Up @@ -233,53 +232,166 @@ func resourceTencentCloudTeoL7AccRuleUpdate(d *schema.ResourceData, meta interfa
}

if needChange {
if v, ok := d.GetOk("rules"); ok {
for _, item := range v.([]interface{}) {
request := teov20220901.NewModifyL7AccRuleRequest()
oldRules, newRules := d.GetChange("rules")
oldRulesList := oldRules.([]interface{})
newRulesList := newRules.([]interface{})
lenOldRules := len(oldRulesList)
lenNewRules := len(newRulesList)
if lenOldRules >= lenNewRules {
needDelIds := make([]*string, 0, lenOldRules)
for i := 0; i < lenOldRules; i++ {
oldRulesMap := oldRulesList[i].(map[string]interface{})
ruleEngineItem := teov20220901.RuleEngineItem{}
// update
if i < lenNewRules {
rulesMap := newRulesList[i].(map[string]interface{})
request := teov20220901.NewModifyL7AccRuleRequest()
request.ZoneId = helper.String(zoneId)
if v, ok := rulesMap["status"].(string); ok && v != "" {
ruleEngineItem.Status = helper.String(v)
}

if v, ok := rulesMap["rule_name"].(string); ok && v != "" {
ruleEngineItem.RuleName = helper.String(v)
}

if v, ok := rulesMap["description"]; ok {
descriptionSet := v.([]interface{})
for i := range descriptionSet {
description := descriptionSet[i].(string)
ruleEngineItem.Description = append(ruleEngineItem.Description, helper.String(description))
}
}

if _, ok := rulesMap["branches"]; ok {
ruleEngineItem.Branches = resourceTencentCloudTeoL7AccRuleGetBranchs(rulesMap)
}

if v, ok := oldRulesMap["rule_id"].(string); ok && v != "" {
ruleEngineItem.RuleId = helper.String(v)
}

request.Rule = &ruleEngineItem
reqErr := resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError {
result, e := meta.(tccommon.ProviderMeta).GetAPIV3Conn().UseTeoV20220901Client().ModifyL7AccRuleWithContext(ctx, request)
if e != nil {
return tccommon.RetryError(e)
} else {
log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), result.ToJsonString())
}
return nil
})

if reqErr != nil {
log.Printf("[CRITAL]%s update teo l7 acc rule failed, reason:%+v", logId, reqErr)
return reqErr
}
} else {
if v, ok := oldRulesMap["rule_id"].(string); ok && v != "" {
needDelIds = append(needDelIds, helper.String(v))
}
}
}

// delete
if len(needDelIds) == 0 {
return resourceTencentCloudTeoL7AccRuleRead(d, meta)
}

if v, ok := d.GetOk("zone_id"); ok {
request.ZoneId = helper.String(v.(string))
request := teov20220901.NewDeleteL7AccRulesRequest()
request.ZoneId = helper.String(zoneId)
request.RuleIds = needDelIds
reqErr := resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError {
result, e := meta.(tccommon.ProviderMeta).GetAPIV3Conn().UseTeoV20220901Client().DeleteL7AccRulesWithContext(ctx, request)
if e != nil {
return tccommon.RetryError(e)
} else {
log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), result.ToJsonString())
}
rulesMap := item.(map[string]interface{})

return nil
})

if reqErr != nil {
log.Printf("[CRITAL]%s delete teo l7 acc rule failed, reason:%+v", logId, reqErr)
return reqErr
}
} else {
needAddRules := make([]*teov20220901.RuleEngineItem, 0, len(newRulesList))
for i := 0; i < lenNewRules; i++ {
rulesMap := newRulesList[i].(map[string]interface{})
ruleEngineItem := teov20220901.RuleEngineItem{}
// update
if v, ok := rulesMap["status"].(string); ok && v != "" {
ruleEngineItem.Status = helper.String(v)
}
if v, ok := rulesMap["rule_id"].(string); ok && v != "" {
ruleEngineItem.RuleId = helper.String(v)
}

if v, ok := rulesMap["rule_name"].(string); ok && v != "" {
ruleEngineItem.RuleName = helper.String(v)
}

if v, ok := rulesMap["description"]; ok {
descriptionSet := v.([]interface{})
for i := range descriptionSet {
description := descriptionSet[i].(string)
ruleEngineItem.Description = append(ruleEngineItem.Description, helper.String(description))
}
}
// if v, ok := rulesMap["rule_priority"].(int); ok {
// ruleEngineItem.RulePriority = helper.IntInt64(v)
// }

if _, ok := rulesMap["branches"]; ok {
ruleEngineItem.Branches = resourceTencentCloudTeoL7AccRuleGetBranchs(rulesMap)
}
request.Rule = &ruleEngineItem

reqErr := resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError {
result, e := meta.(tccommon.ProviderMeta).GetAPIV3Conn().UseTeoV20220901Client().ModifyL7AccRuleWithContext(ctx, request)
if e != nil {
return tccommon.RetryError(e)
} else {
log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), result.ToJsonString())

if i < lenOldRules {
oldRulesMap := oldRulesList[i].(map[string]interface{})
if v, ok := oldRulesMap["rule_id"].(string); ok && v != "" {
ruleEngineItem.RuleId = helper.String(v)
}
return nil
})
if reqErr != nil {
log.Printf("[CRITAL]%s update teo l7 acc rule failed, reason:%+v", logId, reqErr)
return reqErr

request := teov20220901.NewModifyL7AccRuleRequest()
request.ZoneId = helper.String(zoneId)
request.Rule = &ruleEngineItem
reqErr := resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError {
result, e := meta.(tccommon.ProviderMeta).GetAPIV3Conn().UseTeoV20220901Client().ModifyL7AccRuleWithContext(ctx, request)
if e != nil {
return tccommon.RetryError(e)
} else {
log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), result.ToJsonString())
}
return nil
})

if reqErr != nil {
log.Printf("[CRITAL]%s update teo l7 acc rule failed, reason:%+v", logId, reqErr)
return reqErr
}
} else {
needAddRules = append(needAddRules, &ruleEngineItem)
}
}

// add
if len(needAddRules) == 0 {
return resourceTencentCloudTeoL7AccRuleRead(d, meta)
}

request := teov20220901.NewCreateL7AccRulesRequest()
request.ZoneId = helper.String(zoneId)
request.Rules = needAddRules
reqErr := resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError {
result, e := meta.(tccommon.ProviderMeta).GetAPIV3Conn().UseTeoV20220901Client().CreateL7AccRulesWithContext(ctx, request)
if e != nil {
return tccommon.RetryError(e)
} else {
log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), result.ToJsonString())
}

return nil
})

if reqErr != nil {
log.Printf("[CRITAL]%s create teo l7 acc rule failed, reason:%+v", logId, reqErr)
return reqErr
}
}
}
Expand Down
Loading
Loading