Skip to content

fix(clb): [137109981] tencentcloud_clb_target_group_instance_attachment operation increases status query #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/3139.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/tencentcloud_clb_target_group_instance_attachment: operation increases status query
```
43 changes: 40 additions & 3 deletions tencentcloud/services/clb/service_tencentcloud_clb.go
Original file line number Diff line number Diff line change
Expand Up @@ -1277,17 +1277,30 @@ func (me *ClbService) RegisterTargetInstances(ctx context.Context, targetGroupId
Weight: &weight,
},
}

var requestId string
err = resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError {
_, err := me.client.UseClbClient().RegisterTargetGroupInstances(request)
result, err := me.client.UseClbClient().RegisterTargetGroupInstances(request)
if err != nil {
return tccommon.RetryError(err, tccommon.InternalError)
}

if result == nil || result.Response == nil || result.Response.RequestId == nil {
return resource.NonRetryableError(fmt.Errorf("Register target group instance failed, Response is nil."))
}

requestId = *result.Response.RequestId
return nil
})
if err != nil {
return err
}

retryErr := waitForTaskFinish(requestId, me.client.UseClbClient())
if retryErr != nil {
return retryErr
}

return nil
}

Expand All @@ -1301,17 +1314,29 @@ func (me *ClbService) DeregisterTargetInstances(ctx context.Context, targetGroup
},
}

var requestId string
err = resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError {
_, err := me.client.UseClbClient().DeregisterTargetGroupInstances(request)
result, err := me.client.UseClbClient().DeregisterTargetGroupInstances(request)
if err != nil {
return tccommon.RetryError(err, tccommon.InternalError)
}

if result == nil || result.Response == nil || result.Response.RequestId == nil {
return resource.NonRetryableError(fmt.Errorf("Deregister target group instance failed, Response is nil."))
}

requestId = *result.Response.RequestId
return nil
})
if err != nil {
return err
}

retryErr := waitForTaskFinish(requestId, me.client.UseClbClient())
if retryErr != nil {
return retryErr
}

return nil
}

Expand Down Expand Up @@ -1542,9 +1567,10 @@ func (me *ClbService) ModifyTargetGroupInstancesWeight(ctx context.Context, targ
request.TargetGroupId = &targetGroupId
request.TargetGroupInstances = []*clb.TargetGroupInstance{&instance}

var requestId string
err := resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError {
ratelimit.Check(request.GetAction())
_, err := me.client.UseClbClient().ModifyTargetGroupInstancesWeight(request)
result, err := me.client.UseClbClient().ModifyTargetGroupInstancesWeight(request)
if err != nil {
if e, ok := err.(*sdkErrors.TencentCloudSDKError); ok {
if e.GetCode() == "FailedOperation.ResourceInOperating" {
Expand All @@ -1555,12 +1581,23 @@ func (me *ClbService) ModifyTargetGroupInstancesWeight(ctx context.Context, targ
return tccommon.RetryError(err, tccommon.InternalError)
}

if result == nil || result.Response == nil || result.Response.RequestId == nil {
return resource.NonRetryableError(fmt.Errorf("Modify target group instance weight failed, Response is nil."))
}

requestId = *result.Response.RequestId
return nil
})

if err != nil {
return err
}

retryErr := waitForTaskFinish(requestId, me.client.UseClbClient())
if retryErr != nil {
return retryErr
}

return nil
}

Expand Down
Loading