feat(tke): [119900163]tke scale worker taints parameters #2859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyu571
reviewed
Sep 30, 2024
| @@ -496,6 +496,30 @@ func tkeGetInstanceAdvancedPara(dMap map[string]interface{}, meta interface{}) ( | |||
| setting.PreStartUserScript = helper.String(v.(string)) | |||
| } | |||
|
|
|||
| if v, ok := dMap["taints"]; ok { | |||
There was a problem hiding this comment.
taints加到tkeGetInstanceAdvancedPara()里有问题吧。这个方法是多个资源共用的。node_pool也会用这个方法。
lyu571
reviewed
Sep 30, 2024
| @@ -609,3 +625,55 @@ func resourceTencentCloudKubernetesScaleWorkerDeleteOnExit(ctx context.Context) | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| func resourceTencentCloudKubernetesScaleWorkerReadPostFillRequest1(ctx context.Context, req *cvm.DescribeInstancesRequest) error { | |||
There was a problem hiding this comment.
把之前你改的那段放到 Hook 里面了（需要改动 DSL），重新生成代码
andrew-tx
changed the title
andrew-tx
force-pushed
the
dev/tke-node-pool-taints
branch
from
91c8499 to
fbe2f7b
Compare
andrew-tx
force-pushed
the
dev/tke-node-pool-taints
branch
from
372a9b1 to
994b235
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.