Skip to content

[WIP]fix(tke): [119316402] tencentcloud_kubernetes_node_pool support delete taints and labels params #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

SevenEarth
Copy link
Collaborator

No description provided.

@SevenEarth SevenEarth changed the title fix(tke): [119316402] tencentcloud_kubernetes_node_pool support delete taints and labels fix(tke): [119316402] tencentcloud_kubernetes_node_pool support delete taints and labels params Sep 13, 2024
@andrew-tx andrew-tx changed the title fix(tke): [119316402] tencentcloud_kubernetes_node_pool support delete taints and labels params [WIP]fix(tke): [119316402] tencentcloud_kubernetes_node_pool support delete taints and labels params Sep 14, 2024
@@ -7,6 +7,8 @@ import (
"log"
"strings"

tchttp "github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/common/http"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件中是不是不需要引入这个包

@@ -937,6 +922,75 @@ func resourceTencentCloudKubernetesNodePoolUpdate(d *schema.ResourceData, meta i
}
}

if d.HasChange("taints") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段代码应该要加到 Hook 里面

@SevenEarth SevenEarth closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants