fix(vpc): [119554452] tencentcloud_route_table_entry fix creation failure

.changelog/2808.txt

@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/tencentcloud_route_table_entry: fix creation failure
+```

tencentcloud/services/vpc/resource_tc_route_table_entry.go

@@ -133,13 +133,13 @@ func resourceTencentCloudVpcRouteEntryCreate(d *schema.ResourceData, meta interf
 		request := vpc.NewDisableRoutesRequest()
 		request.RouteTableId = &routeTableId
 		request.RouteIds = []*uint64{helper.Int64Uint64(entryId)}
-		err := service.DisableRoutes(ctx, request)
+		err = service.DisableRoutes(ctx, request)
 		if err != nil {
 			return err
 		}
 	}
 
-	return nil
+	return resourceTencentCloudVpcRouteEntryRead(d, meta)
 }
 
 func resourceTencentCloudVpcRouteEntryRead(d *schema.ResourceData, meta interface{}) error {

tencentcloud/services/vpc/resource_tc_route_table_entry.md

@@ -4,37 +4,42 @@ Example Usage
 
 ```hcl
 variable "availability_zone" {
-  default = "na-siliconvalley-1"
+  default = "ap-guangzhou-4"
 }
 
-resource "tencentcloud_vpc" "foo" {
-  name       = "ci-temp-test"
+# create vpc
+resource "tencentcloud_vpc" "vpc" {
+  name       = "vpc"
   cidr_block = "10.0.0.0/16"
 }
 
-resource "tencentcloud_subnet" "foo" {
-  vpc_id            = tencentcloud_vpc.foo.id
-  name              = "terraform test subnet"
+# create subnet
+resource "tencentcloud_subnet" "subnet" {
+  vpc_id            = tencentcloud_vpc.vpc.id
+  name              = "subnet"
   cidr_block        = "10.0.12.0/24"
   availability_zone = var.availability_zone
-  route_table_id    = tencentcloud_route_table.foo.id
+  route_table_id    = tencentcloud_route_table.example.id
 }
 
-resource "tencentcloud_route_table" "foo" {
-  vpc_id = tencentcloud_vpc.foo.id
-  name   = "ci-temp-test-rt"
+# create route table
+resource "tencentcloud_route_table" "example" {
+  vpc_id = tencentcloud_vpc.vpc.id
+  name   = "tf-example"
 }
 
-resource "tencentcloud_route_table_entry" "instance" {
-  route_table_id         = tencentcloud_route_table.foo.id
+# create route table entry
+resource "tencentcloud_route_table_entry" "example" {
+  route_table_id         = tencentcloud_route_table.example.id
   destination_cidr_block = "10.4.4.0/24"
   next_type              = "EIP"
   next_hub               = "0"
-  description            = "ci-test-route-table-entry"
+  description            = "describe"
 }
 
+# output
 output "item_id" {
-  value = tencentcloud_route_table_entry.instance.route_item_id
+  value = tencentcloud_route_table_entry.example.route_item_id
 }
 ```
 
@@ -43,5 +48,5 @@ Import
 Route table entry can be imported using the id, e.g.
 
 ```
-$ terraform import tencentcloud_route_table_entry.foo 83517.rtb-mlhpg09u
-```
+$ terraform import tencentcloud_route_table_entry.example 3065857.rtb-b050fg94
+```

tencentcloud/services/vpc/service_tencentcloud_vpc.go

@@ -12,7 +12,6 @@ import (
 	"strconv"
 	"strings"
 	"sync"
-	"time"
 
 	tccommon "github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud/common"
 
@@ -1174,36 +1173,26 @@ func (me *VpcService) CreateRoutes(ctx context.Context,
 		return
 	}
 
-	entryId, errRet = me.GetRouteId(ctx, routeTableId, destinationCidrBlock, nextType, nextHub, description)
-
-	if errRet != nil {
-		time.Sleep(3 * time.Second)
-		entryId, errRet = me.GetRouteId(ctx, routeTableId, destinationCidrBlock, nextType, nextHub, description)
+	if response == nil {
+		return
 	}
 
-	if errRet != nil {
-		time.Sleep(5 * time.Second)
-		entryId, errRet = me.GetRouteId(ctx, routeTableId, destinationCidrBlock, nextType, nextHub, description)
+	if *response.Response.TotalCount != 1 {
+		errRet = fmt.Errorf("CreateRoutes return %d routeTable. but we only request 1.\n", *response.Response.TotalCount)
+		return
 	}
 
-	/*
-		if *(response.Response.TotalCount) != 1 {
-			errRet = fmt.Errorf("CreateRoutes  return %d routeTable . but we only request 1.", *response.Response.TotalCount)
-			return
-		}
-
-		if len(response.Response.RouteTableSet) != 1 {
-			errRet = fmt.Errorf("CreateRoutes  return %d routeTable  info . but we only request 1.", len(response.Response.RouteTableSet))
-			return
-		}
+	if len(response.Response.RouteTableSet) != 1 {
+		errRet = fmt.Errorf("CreateRoutes return %d routeTable info. but we only request 1.\n", len(response.Response.RouteTableSet))
+		return
+	}
 
-		if len(response.Response.RouteTableSet[0].RouteSet) != 1 {
-			errRet = fmt.Errorf("CreateRoutes  return %d routeTableSet  info . but we only create 1.", len(response.Response.RouteTableSet[0].RouteSet))
-			return
-		}
+	if len(response.Response.RouteTableSet[0].RouteSet) != 1 {
+		errRet = fmt.Errorf("CreateRoutes return %d routeTableSet info. but we only create 1.\n", len(response.Response.RouteTableSet[0].RouteSet))
+		return
+	}
 
-		entryId = int64(*response.Response.RouteTableSet[0].RouteSet[0].RouteId)
-	*/
+	entryId = int64(*response.Response.RouteTableSet[0].RouteSet[0].RouteId)
 
 	return
 }

website/docs/r/route_table_entry.html.markdown

@@ -15,37 +15,42 @@ Provides a resource to create an entry of a routing table.
 
 ```hcl
 variable "availability_zone" {
-  default = "na-siliconvalley-1"
+  default = "ap-guangzhou-4"
 }
 
-resource "tencentcloud_vpc" "foo" {
-  name       = "ci-temp-test"
+# create vpc
+resource "tencentcloud_vpc" "vpc" {
+  name       = "vpc"
   cidr_block = "10.0.0.0/16"
 }
 
-resource "tencentcloud_subnet" "foo" {
-  vpc_id            = tencentcloud_vpc.foo.id
-  name              = "terraform test subnet"
+# create subnet
+resource "tencentcloud_subnet" "subnet" {
+  vpc_id            = tencentcloud_vpc.vpc.id
+  name              = "subnet"
   cidr_block        = "10.0.12.0/24"
   availability_zone = var.availability_zone
-  route_table_id    = tencentcloud_route_table.foo.id
+  route_table_id    = tencentcloud_route_table.example.id
 }
 
-resource "tencentcloud_route_table" "foo" {
-  vpc_id = tencentcloud_vpc.foo.id
-  name   = "ci-temp-test-rt"
+# create route table
+resource "tencentcloud_route_table" "example" {
+  vpc_id = tencentcloud_vpc.vpc.id
+  name   = "tf-example"
 }
 
-resource "tencentcloud_route_table_entry" "instance" {
-  route_table_id         = tencentcloud_route_table.foo.id
+# create route table entry
+resource "tencentcloud_route_table_entry" "example" {
+  route_table_id         = tencentcloud_route_table.example.id
   destination_cidr_block = "10.4.4.0/24"
   next_type              = "EIP"
   next_hub               = "0"
-  description            = "ci-test-route-table-entry"
+  description            = "describe"
 }
 
+# output
 output "item_id" {
-  value = tencentcloud_route_table_entry.instance.route_item_id
+  value = tencentcloud_route_table_entry.example.route_item_id
 }
 ```
 
@@ -73,6 +78,6 @@ In addition to all arguments above, the following attributes are exported:
 Route table entry can be imported using the id, e.g.
 
 ```
-$ terraform import tencentcloud_route_table_entry.foo 83517.rtb-mlhpg09u
+$ terraform import tencentcloud_route_table_entry.example 3065857.rtb-b050fg94
 ```