Skip to content

fix(dnspod): [123456789] dns-record weight update to 0 #2770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2024
Merged

fix(dnspod): [123456789] dns-record weight update to 0 #2770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24a23f2
fix dns record weight update to 0
Aug 13, 2024
d4876bd
add changelog
Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/2770.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/tencentcloud_dnspod_record: fix weight auto update to 0 when update value
```
12 changes: 6 additions & 6 deletions tencentcloud/services/dnspod/resource_tc_dnspod_record.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,19 +235,19 @@ func resourceTencentCloudDnspodRecordUpdate(d *schema.ResourceData, meta interfa
request.Value = &value
request.SubDomain = &subDomain

if d.HasChange("status") {
status := d.Get("status").(string)
if v, ok := d.GetOk("status"); ok {
status := v.(string)
request.Status = &status
}
if v, ok := d.GetOk("mx"); ok {
request.MX = helper.IntUint64(v.(int))
}
if d.HasChange("ttl") {
ttl := d.Get("ttl").(int)
if v, ok := d.GetOk("ttl"); ok {
ttl := v.(int)
request.TTL = helper.IntUint64(ttl)
}
if d.HasChange("weight") {
weight := d.Get("weight").(int)
if v, ok := d.GetOk("weight"); ok {
weight := v.(int)
request.Weight = helper.IntUint64(weight)
}
d.Partial(true)
Expand Down
41 changes: 35 additions & 6 deletions tencentcloud/services/dnspod/resource_tc_dnspod_record_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (
func TestAccTencentCloudDnspodRecordResource_basic(t *testing.T) {
t.Parallel()
resource.Test(t, resource.TestCase{
PreCheck: func() { tcacctest.AccPreCheckCommon(t, tcacctest.ACCOUNT_TYPE_PREPAY) },
PreCheck: func() { tcacctest.AccPreCheck(t) },
Providers: tcacctest.AccProviders,
CheckDestroy: testAccCheckDnspodRecordDestroy,
Steps: []resource.TestStep{
Expand All @@ -35,6 +35,7 @@ func TestAccTencentCloudDnspodRecordResource_basic(t *testing.T) {
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "record_type", "A"),
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "record_line", "默认"),
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "remark", "terraform-test"),
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "weight", "100"),
),
},
{
Expand All @@ -48,6 +49,21 @@ func TestAccTencentCloudDnspodRecordResource_basic(t *testing.T) {
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "record_type", "A"),
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "record_line", "默认"),
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "remark", "terraform-test1"),
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "weight", "100"),
),
},
{
Config: testAccTencentCloudDnspodRecordValueUpdate,
Check: resource.ComposeTestCheckFunc(
testAccCheckDnspodRecordExists("tencentcloud_dnspod_record.demo"),
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "domain", "iac-tf.cloud"),
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "value", "1.2.3.10"),
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "sub_domain", "demo"),
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "status", "ENABLE"),
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "record_type", "A"),
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "record_line", "默认"),
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "remark", "terraform-test1"),
resource.TestCheckResourceAttr("tencentcloud_dnspod_record.demo", "weight", "100"),
),
},
{
Expand All @@ -62,7 +78,7 @@ func TestAccTencentCloudDnspodRecordResource_basic(t *testing.T) {
func TestAccTencentCloudDnspodRecordResource_MX(t *testing.T) {
t.Parallel()
resource.Test(t, resource.TestCase{
PreCheck: func() { tcacctest.AccPreCheckCommon(t, tcacctest.ACCOUNT_TYPE_PREPAY) },
PreCheck: func() { tcacctest.AccPreCheck(t) },
Providers: tcacctest.AccProviders,
CheckDestroy: testAccCheckDnspodRecordDestroy,
Steps: []resource.TestStep{
Expand Down Expand Up @@ -182,24 +198,37 @@ func testAccCheckDnspodRecordDestroy(s *terraform.State) error {
}

const testAccTencentCloudDnspodRecord = `
resource "tencentcloud_dnspod_record" "demo" {
resource "tencentcloud_dnspod_record" "demo" {
domain="iac-tf.cloud"
record_type="A"
record_line="默认"
value="1.2.3.9"
sub_domain="demo"
remark="terraform-test"
}
weight=100
}
`
const testAccTencentCloudDnspodRecordRemarkUp = `
resource "tencentcloud_dnspod_record" "demo" {
resource "tencentcloud_dnspod_record" "demo" {
domain="iac-tf.cloud"
record_type="A"
record_line="默认"
value="1.2.3.9"
sub_domain="demo"
remark="terraform-test1"
}
weight=100
}
`
const testAccTencentCloudDnspodRecordValueUpdate = `
resource "tencentcloud_dnspod_record" "demo" {
domain="iac-tf.cloud"
record_type="A"
record_line="默认"
value="1.2.3.10"
sub_domain="demo"
remark="terraform-test1"
weight=100
}
`

const testAccTencentCloudDnspodRecordMx = `
Expand Down
Loading