Skip to content

fix(tke): [118133957] support retry #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/2723.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/tencentcloud_kubernetes_scale_worker: support retry
```
Original file line number Diff line number Diff line change
Expand Up @@ -435,11 +435,60 @@
}

//修改id设置,不符合id规则
id := clusterId + tccommon.FILED_SP + strings.Join(instanceIds, tccommon.FILED_SP)
id := clusterId + tccommon.FILED_SP + strings.Join(instanceIds, tccommon.COMMA_SP)
d.SetId(id)

//wait for LANIP
time.Sleep(tccommon.ReadRetryTimeout)

// wait for all instances status running
waitRequest := tke.NewDescribeClusterInstancesRequest()
waitRequest.ClusterId = &clusterId
waitRequest.InstanceIds = helper.Strings(instanceIds)
waitRequest.Offset = helper.Int64(0)
waitRequest.Limit = helper.Int64(100)
err = resource.Retry(tccommon.ReadRetryTimeout*5, func() *resource.RetryError {
result, e := meta.(tccommon.ProviderMeta).GetAPIV3Conn().UseTkeClient().DescribeClusterInstances(waitRequest)
if e != nil {
return tccommon.RetryError(e)
} else {
log.Printf("[DEBUG] api[%s] success, request body [%s], response body [%s]\n", waitRequest.GetAction(), waitRequest.ToJsonString(), result.ToJsonString())
}

// check instances status
tmpInstanceSet := result.Response.InstanceSet
if tmpInstanceSet == nil || len(tmpInstanceSet) == 0 {

Check failure on line 460 in tencentcloud/services/tke/resource_tc_kubernetes_scale_worker_extension.go

View workflow job for this annotation

GitHub Actions / golangci-lint

S1009: should omit nil check; len() for nil slices is defined as zero (gosimple)
return resource.NonRetryableError(fmt.Errorf("there is no instances in set"))
} else {
var stop int
for _, v := range instanceIds {
for _, instance := range tmpInstanceSet {
if v == *instance.InstanceId {
if *instance.InstanceState == "running" {
stop += 1
} else if *instance.InstanceState == "failed" {
stop += 1
log.Printf("instance:%s status is failed.", v)
} else {
continue
}
}
}
}

if stop == len(instanceIds) {
return nil
}
}

e = fmt.Errorf("cluster instances is still initializing.")
return tccommon.RetryError(e)
})

if err != nil {
log.Printf("[CRITAL] kubernetes scale worker instances status error, reason:%+v", err)
}

return nil
}

Expand Down
Loading