-
Notifications
You must be signed in to change notification settings - Fork 140
feat(mongodb): [118133960]support mongodb encryption and backup rule #2692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| ```release-note:new-resource | ||
| tencentcloud_mongodb_instance_transparent_data_encryption | ||
| ``` | ||
|
|
||
| ```release-note:new-resource | ||
| tencentcloud_mongodb_instance_backup_rule | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
128 changes: 128 additions & 0 deletions
128
tencentcloud/services/mongodb/resource_tc_mongodb_instance_backup_rule.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| package mongodb | ||
|
|
||
| import ( | ||
| "log" | ||
|
|
||
| "github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource" | ||
| "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema" | ||
| mongodb "github.com/tencentcloud/tencentcloud-sdk-go/tencentcloud/mongodb/v20190725" | ||
| tccommon "github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud/common" | ||
| "github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud/internal/helper" | ||
| "github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud/ratelimit" | ||
| ) | ||
|
|
||
| func ResourceTencentCloudMongodbInstanceBackupRule() *schema.Resource { | ||
| return &schema.Resource{ | ||
| Create: resourceTencentCloudMongodbInstanceBackupRuleCreate, | ||
| Read: resourceTencentCloudMongodbInstanceBackupRuleRead, | ||
| Update: resourceTencentCloudMongodbInstanceBackupRuleUpdate, | ||
| Delete: resourceTencentCloudMongodbInstanceBackupRuleDelete, | ||
| Importer: &schema.ResourceImporter{ | ||
| State: schema.ImportStatePassthrough, | ||
| }, | ||
| Schema: map[string]*schema.Schema{ | ||
| "instance_id": { | ||
| Required: true, | ||
| ForceNew: true, | ||
| Type: schema.TypeString, | ||
| Description: "Instance id.", | ||
| }, | ||
|
|
||
| "backup_method": { | ||
| Required: true, | ||
| Type: schema.TypeInt, | ||
| Description: "Set automatic backup method. Valid values:\n" + | ||
| "- 0: Logical backup;\n" + | ||
| "- 1: Physical backup;\n" + | ||
| "- 3: Snapshot backup (supported only in cloud disk version).", | ||
| }, | ||
|
|
||
| "backup_time": { | ||
| Required: true, | ||
| Type: schema.TypeInt, | ||
| Description: "Set the start time for automatic backup. The value range is: [0,23]. For example, setting this parameter to 2 means that backup starts at 02:00.", | ||
| }, | ||
|
|
||
| "backup_retention_period": { | ||
| Optional: true, | ||
| Computed: true, | ||
| Type: schema.TypeInt, | ||
| Description: "Specify the number of days to save backup data. The default is 7 days, and the support settings are 7, 30, 90, 180, 365.", | ||
| }, | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| func resourceTencentCloudMongodbInstanceBackupRuleCreate(d *schema.ResourceData, meta interface{}) error { | ||
| defer tccommon.LogElapsed("resource.tencentcloud_mongodb_instance_backup_rule.create")() | ||
| defer tccommon.InconsistentCheck(d, meta)() | ||
|
|
||
| logId := tccommon.GetLogId(tccommon.ContextNil) | ||
| var ( | ||
| request = mongodb.NewSetBackupRulesRequest() | ||
| ) | ||
| instanceId := d.Get("instance_id").(string) | ||
| request.InstanceId = helper.String(instanceId) | ||
|
|
||
| if v, _ := d.GetOk("backup_method"); v != nil { | ||
| request.BackupMethod = helper.IntUint64(v.(int)) | ||
| } | ||
|
|
||
| if v, _ := d.GetOk("backup_time"); v != nil { | ||
| request.BackupTime = helper.IntUint64(v.(int)) | ||
| } | ||
|
|
||
| if v, ok := d.GetOkExists("backup_retention_period"); ok { | ||
| request.BackupRetentionPeriod = helper.IntUint64(v.(int)) | ||
| } | ||
|
|
||
| err := resource.Retry(tccommon.WriteRetryTimeout, func() *resource.RetryError { | ||
| result, e := meta.(tccommon.ProviderMeta).GetAPIV3Conn().UseMongodbClient().SetBackupRules(request) | ||
| if e != nil { | ||
| return tccommon.RetryError(e) | ||
| } else { | ||
| log.Printf("[DEBUG]%s api[%s] success, request body [%s], response body [%s]\n", logId, request.GetAction(), request.ToJsonString(), result.ToJsonString()) | ||
| } | ||
| return nil | ||
| }) | ||
| if err != nil { | ||
| log.Printf("[CRITAL]%s operate mongodb backupRule failed, reason:%+v", logId, err) | ||
| return err | ||
| } | ||
|
|
||
| d.SetId(instanceId) | ||
|
|
||
| return resourceTencentCloudMongodbInstanceBackupRuleRead(d, meta) | ||
| } | ||
|
|
||
| func resourceTencentCloudMongodbInstanceBackupRuleRead(d *schema.ResourceData, meta interface{}) error { | ||
| defer tccommon.LogElapsed("resource.tencentcloud_mongodb_instance_backup_rule.read")() | ||
| defer tccommon.InconsistentCheck(d, meta)() | ||
|
|
||
| request := mongodb.NewDescribeBackupRulesRequest() | ||
| request.InstanceId = helper.String(d.Id()) | ||
| ratelimit.Check(request.GetAction()) | ||
| response, err := meta.(tccommon.ProviderMeta).GetAPIV3Conn().UseMongodbClient().DescribeBackupRules(request) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| _ = d.Set("instance_id", d.Id()) | ||
| _ = d.Set("backup_method", response.Response.BackupMethod) | ||
| _ = d.Set("backup_time", response.Response.BackupTime) | ||
| _ = d.Set("backup_retention_period", response.Response.BackupSaveTime) | ||
| return nil | ||
| } | ||
|
|
||
| func resourceTencentCloudMongodbInstanceBackupRuleUpdate(d *schema.ResourceData, meta interface{}) error { | ||
| defer tccommon.LogElapsed("resource.tencentcloud_mongodb_instance_transparent_data_encryption.update")() | ||
| defer tccommon.InconsistentCheck(d, meta)() | ||
|
|
||
| return resourceTencentCloudMongodbInstanceBackupRuleCreate(d, meta) | ||
| } | ||
|
|
||
| func resourceTencentCloudMongodbInstanceBackupRuleDelete(d *schema.ResourceData, meta interface{}) error { | ||
| defer tccommon.LogElapsed("resource.tencentcloud_mongodb_instance_backup_rule.delete")() | ||
| defer tccommon.InconsistentCheck(d, meta)() | ||
|
|
||
| return nil | ||
| } | ||
19 changes: 19 additions & 0 deletions
19
tencentcloud/services/mongodb/resource_tc_mongodb_instance_backup_rule.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| Provides a resource to create mongodb backup rule | ||
|
|
||
| Example Usage | ||
|
|
||
| ```hcl | ||
| resource "tencentcloud_mongodb_backup_rule" "backup_rule" { | ||
| instance_id = "cmgo-xxxxxx" | ||
| backup_method = 0 | ||
| backup_time = 10 | ||
| } | ||
| ``` | ||
|
|
||
| Import | ||
|
|
||
| mongodb backup_rule can be imported using the id, e.g. | ||
|
|
||
| ``` | ||
| terraform import tencentcloud_mongodb_backup_rule.backup_rule ${instanceId} | ||
| ``` |
109 changes: 109 additions & 0 deletions
109
tencentcloud/services/mongodb/resource_tc_mongodb_instance_backup_rule_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| package mongodb_test | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| tcacctest "github.com/tencentcloudstack/terraform-provider-tencentcloud/tencentcloud/acctest" | ||
|
|
||
| "github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource" | ||
| ) | ||
|
|
||
| func TestAccTencentCloudMongodbInstanceBackupRuleResource_basic(t *testing.T) { | ||
| t.Parallel() | ||
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { | ||
| tcacctest.AccPreCheck(t) | ||
| }, | ||
| Providers: tcacctest.AccProviders, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccMongodbInstanceBackupRule, | ||
| Check: resource.ComposeTestCheckFunc( | ||
| resource.TestCheckResourceAttrSet("tencentcloud_mongodb_instance_backup_rule.backup_rule", "id"), | ||
| resource.TestCheckResourceAttrSet("tencentcloud_mongodb_instance_backup_rule.backup_rule", "instance_id"), | ||
| resource.TestCheckResourceAttrSet("tencentcloud_mongodb_instance_backup_rule.backup_rule", "backup_method"), | ||
| resource.TestCheckResourceAttr("tencentcloud_mongodb_instance_backup_rule.backup_rule", "backup_time", "10"), | ||
| resource.TestCheckResourceAttrSet("tencentcloud_mongodb_instance_backup_rule.backup_rule", "backup_retention_period"), | ||
| ), | ||
| }, | ||
| { | ||
| Config: testAccMongodbInstanceBackupRuleUpdate, | ||
| Check: resource.ComposeTestCheckFunc( | ||
| resource.TestCheckResourceAttr("tencentcloud_mongodb_instance_backup_rule.backup_rule", "backup_time", "14"), | ||
| ), | ||
| }, | ||
| { | ||
| ResourceName: "tencentcloud_mongodb_instance_backup_rule.backup_rule", | ||
| ImportState: true, | ||
| }, | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| const testAccMongodbInstanceBackupRule = tcacctest.DefaultMongoDBSpec + ` | ||
| resource "tencentcloud_vpc" "vpc" { | ||
| name = "mongodb-instance-vpc" | ||
| cidr_block = "10.0.0.0/16" | ||
| } | ||
|
|
||
| resource "tencentcloud_subnet" "subnet" { | ||
| vpc_id = tencentcloud_vpc.vpc.id | ||
| name = "mongodb-instance-subnet" | ||
| cidr_block = "10.0.0.0/16" | ||
| availability_zone = "ap-guangzhou-3" | ||
| } | ||
|
|
||
| resource "tencentcloud_mongodb_instance" "mongodb" { | ||
| instance_name = "tf-mongodb-encryption-test" | ||
| memory = local.memory | ||
| volume = local.volume | ||
| engine_version = local.engine_version | ||
| machine_type = local.machine_type | ||
| security_groups = [local.security_group_id] | ||
| available_zone = "ap-guangzhou-3" | ||
| project_id = 0 | ||
| password = "test1234" | ||
| vpc_id = tencentcloud_vpc.vpc.id | ||
| subnet_id = tencentcloud_subnet.subnet.id | ||
| } | ||
|
|
||
| resource "tencentcloud_mongodb_instance_backup_rule" "backup_rule" { | ||
| instance_id = tencentcloud_mongodb_instance.mongodb.id | ||
| backup_method = 0 | ||
| backup_time = 10 | ||
| } | ||
| ` | ||
|
|
||
| const testAccMongodbInstanceBackupRuleUpdate = tcacctest.DefaultMongoDBSpec + ` | ||
| resource "tencentcloud_vpc" "vpc" { | ||
| name = "mongodb-instance-vpc" | ||
| cidr_block = "10.0.0.0/16" | ||
| } | ||
|
|
||
| resource "tencentcloud_subnet" "subnet" { | ||
| vpc_id = tencentcloud_vpc.vpc.id | ||
| name = "mongodb-instance-subnet" | ||
| cidr_block = "10.0.0.0/16" | ||
| availability_zone = "ap-guangzhou-3" | ||
| } | ||
|
|
||
| resource "tencentcloud_mongodb_instance" "mongodb" { | ||
| instance_name = "tf-mongodb-encryption-test" | ||
| memory = local.memory | ||
| volume = local.volume | ||
| engine_version = local.engine_version | ||
| machine_type = local.machine_type | ||
| security_groups = [local.security_group_id] | ||
| available_zone = "ap-guangzhou-3" | ||
| project_id = 0 | ||
| password = "test1234" | ||
| vpc_id = tencentcloud_vpc.vpc.id | ||
| subnet_id = tencentcloud_subnet.subnet.id | ||
| } | ||
|
|
||
| resource "tencentcloud_mongodb_instance_backup_rule" "backup_rule" { | ||
| instance_id = tencentcloud_mongodb_instance.mongodb.id | ||
| backup_method = 0 | ||
| backup_time = 14 | ||
| } | ||
| ` |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forcenew