fix(postgresql): [117252443] support params db_major_version create resource
#2618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SevenEarth
changed the title
db_major_version create resourcedb_major_version create resource
andrew-tx
reviewed
May 6, 2024
| Optional: true, | ||
| Default: "10.4", |
There was a problem hiding this comment.
如果用户engine_version和db_major_version都不填写 会在代码中手动设置engine_version：10.4
| @@ -438,8 +442,8 @@ func resourceTencentCloudPostgresqlInstanceCreate(d *schema.ResourceData, meta i | |||
| return outErr | |||
| } | |||
|
|
|||
| if specVersion == "" { | |||
| return fmt.Errorf(`The "engine_version" value: "%s" is invalid, Valid values are one of: "%s"`, dbVersion, strings.Join(allowVersion, `", "`)) | |||
| if majorVersion == "" && specVersion == "" { | |||
There was a problem hiding this comment.
majorVersion 和 specVersion 参数必须传一个是吗
There was a problem hiding this comment.
majorVersion和specVersion参数主要对应的是客户传入的engine_version和db_major_version
andrew-tx
changed the title
db_major_version create resourcedb_major_version create resource
SevenEarth
changed the title
db_major_version create resourcedb_major_version create resource
SevenEarth
changed the title
db_major_version create resourcedb_major_version create resource
SevenEarth
changed the title
db_major_version create resourcedb_major_version create resource
|
create: |
SevenEarth
added a commit
that referenced
this pull request
Jun 12, 2024
… resource (#2618) * add * add * add * add * add * add * add * add * add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add