-
Notifications
You must be signed in to change notification settings - Fork 140
feat(tse): [115375235] support tse network access_control #2581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
}) | ||
} | ||
|
||
const testAccTseCngwNetworkAccessControl = ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里 lint 检查没有通过
ResourceName: "tencentcloud_tse_cngw_network_access_control.cngw_network_access_control", | ||
ImportState: true, | ||
ImportStateVerify: true, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
测试用例修改资源的场景没有覆盖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是个config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config 应该也支持修改吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat(tse): [115375235] support tse network access_control * feat: add change log * fix: modify test * fix: modify test
No description provided.