-
Notifications
You must be signed in to change notification settings - Fork 140
fix(vod): [116206298] update vod resource #2569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"preserve_hdr_switch": { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Default: "OFF", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
后台接口没有设置默认值吗?
.changelog/2569.txt
Outdated
@@ -0,0 +1,19 @@ | |||
```release-note:enhancement | |||
resource/tencentcloud_vod_adaptive_dynamic_streaming_template: support params vcrf, gop, preserve_hdr_switch, codec_tag; compatible id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compatible id 是什么意思呢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的 changelog 我们要不也调整下,改成类似:
resource/tencentcloud_vod_adaptive_dynamic_streaming_template: Add vcrf, gop, preserve_hdr_switch and codec_tag arguments. Adjust resource unique id to xxx.
"codec_tag": { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Default: "hvc1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的 default 可以去掉吗
"remove_video": { | ||
Type: schema.TypeBool, | ||
Optional: true, | ||
Default: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的 default 可以去掉吗
"max_video_bitrate": { | ||
Type: schema.TypeInt, | ||
Optional: true, | ||
Default: 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里 default 是否可以去掉
"format": { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
Default: "jpg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的 default 可以去掉吗
@@ -407,6 +542,68 @@ func generateMediaProcessTask(d *schema.ResourceData) (mediaReq *vod.MediaProces | |||
}(item["definition"].(string)), | |||
WatermarkSet: genWatermarkList(item), | |||
MosaicSet: genMosaicList(item), | |||
TraceWatermark: func() *vod.TraceWatermarkInput { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下面这段逻辑是干嘛的呢,感觉有点复杂
e46372f
to
7088554
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.