Skip to content

fix(cls): [116280037]support hot_period, describes params #2545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 1, 2024
Merged

Conversation

SevenEarth
Copy link
Collaborator

fix/cls

@SevenEarth SevenEarth added the run check run check label Feb 29, 2024
@SevenEarth SevenEarth added run check run check and removed run check run check labels Feb 29, 2024
},
"period": {
Type: schema.TypeInt,
Optional: true,
Computed: true,
Description: "Lifecycle in days. Value range: 1~366. Default value: 30.",
},
"hot_period": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为啥要加 Computed 属性呢

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为这个参数不设置产品会返回0,不加computed会出现changed

@@ -91,7 +91,7 @@ func TestAccTencentCloudClsTopic_basic(t *testing.T) {
Config: testAccClsTopic,
Check: resource.ComposeTestCheckFunc(
testAccCheckClsTopicExists("tencentcloud_cls_topic.topic"),
resource.TestCheckResourceAttr("tencentcloud_cls_topic.topic", "topic_name", "tf-topic-test"),
resource.TestCheckResourceAttr("tencentcloud_cls_topic.topic", "topic_name", "tf_example"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个用例好像也没有覆盖修改的场景是吧

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有覆盖修改 这里我更新下

@SevenEarth SevenEarth added run check run check and removed run check run check labels Mar 1, 2024
Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx merged commit 0c1c75c into master Mar 1, 2024
@andrew-tx andrew-tx deleted the fix/cls branch March 1, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run check run check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants