-
Notifications
You must be signed in to change notification settings - Fork 141
fix(cls): [116280037]support hot_period, describes params #2545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
}, | ||
"period": { | ||
Type: schema.TypeInt, | ||
Optional: true, | ||
Computed: true, | ||
Description: "Lifecycle in days. Value range: 1~366. Default value: 30.", | ||
}, | ||
"hot_period": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为啥要加 Computed 属性呢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为这个参数不设置产品会返回0,不加computed会出现changed
@@ -91,7 +91,7 @@ func TestAccTencentCloudClsTopic_basic(t *testing.T) { | |||
Config: testAccClsTopic, | |||
Check: resource.ComposeTestCheckFunc( | |||
testAccCheckClsTopicExists("tencentcloud_cls_topic.topic"), | |||
resource.TestCheckResourceAttr("tencentcloud_cls_topic.topic", "topic_name", "tf-topic-test"), | |||
resource.TestCheckResourceAttr("tencentcloud_cls_topic.topic", "topic_name", "tf_example"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个用例好像也没有覆盖修改的场景是吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有覆盖修改 这里我更新下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix/cls