feat: organization add resource #2521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiMengXS
changed the title
WeiMengXS
changed the title
andrew-tx
reviewed
Feb 5, 2024
| return err | ||
| } | ||
| shareMemberUins := strings.Join(shareMemberUin, tccommon.COMMA_SP) | ||
| d.SetId(strings.Join(append([]string{area, unitId, shareMemberUins}), tccommon.FILED_SP)) |
There was a problem hiding this comment.
这里为啥 Id 中要把 shareMemberUins 加进来呢
There was a problem hiding this comment.
不加进来的话，查询到时候，没办法知道传入的uin是否绑定成功。
| return nil | ||
| } | ||
|
|
||
| _ = d.Set("unit_id", unitId) |
There was a problem hiding this comment.
id有些特殊，没办法直接引用到另一个资源上
| Check: resource.ComposeTestCheckFunc(resource.TestCheckResourceAttrSet("tencentcloud_organization_org_share_unit_member.org_share_unit_member", "id"), | ||
| resource.TestCheckResourceAttrSet("tencentcloud_organization_org_share_unit_member.org_share_unit_member", "unit_id"), | ||
| resource.TestCheckResourceAttrSet("tencentcloud_organization_org_share_unit_member.org_share_unit_member", "area"), | ||
| resource.TestCheckResourceAttrSet("tencentcloud_organization_org_share_unit_member.org_share_unit_member", "members.#"), |
WeiMengXS
force-pushed
the
feat/organization-share-unit
branch
from
cdfde35 to
34bae35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add resource tencentcloud_organization_org_share_unit