Skip to content

resource scanning added to obtain creator code #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

bruceybian
Copy link
Collaborator

No description provided.

}
}

func parseUserIdentityFields(data map[string]interface{}) (accountId, principalId, userName string) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里首字母要大写吗

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以先不用大写,这个目前只在cloud_common.go内调用,属于私有的,外部不会调用到,以后有需要可以改成大写

Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx merged commit bea7f20 into master Feb 5, 2024
@andrew-tx andrew-tx deleted the coding-test/resource-scan-cloud-common branch February 5, 2024 05:41
andrew-tx pushed a commit that referenced this pull request Feb 5, 2024
* fix/tdmq_rabbitmq

* fix/tdmq_rabbitmq

* feat: add para (#2512)

* feat: add para

* feat: add para

* resource scanning added to obtain creator code (#2519)

* resource scanning added to obtain creator code

* add get resource creator account info code

* add resource create action

* update query rule

* update create time parse code

* fix lighthouse import (#2508)

* fix lighthouse import

* import set default

* update

* fix update && fix unittest

* add changelog

---------

Co-authored-by: mikatong <[email protected]>

* add

---------

Co-authored-by: Wmxs <[email protected]>
Co-authored-by: bruceybian <[email protected]>
Co-authored-by: tongyiming <[email protected]>
Co-authored-by: mikatong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants