Skip to content

feat(csip): [116351437]add resource for csip #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 1, 2024
Merged

feat(csip): [116351437]add resource for csip #2498

merged 15 commits into from
Mar 1, 2024

Conversation

SevenEarth
Copy link
Collaborator

feat/csip

@SevenEarth SevenEarth changed the title feat/csip [WIP]feat/csip Jan 31, 2024
@SevenEarth SevenEarth added the run check run check label Feb 29, 2024
@SevenEarth SevenEarth changed the title [WIP]feat/csip feat/csip: [1]add resource for csip Feb 29, 2024
@SevenEarth SevenEarth changed the title feat/csip: [1]add resource for csip feat(csip): [1]add resource for csip Feb 29, 2024
@SevenEarth SevenEarth changed the title feat(csip): [1]add resource for csip feat(csip): [111111111]add resource for csip Feb 29, 2024
@SevenEarth SevenEarth changed the title feat(csip): [111111111]add resource for csip feat(csip): [116351437]add resource for csip Feb 29, 2024
resource.TestCheckResourceAttr("tencentcloud_csip_risk_center.example", "scan_plan_content", "46 51 16 */1 * * *"),
resource.TestCheckResourceAttrSet("tencentcloud_csip_risk_center.example", "task_mode"),
resource.TestCheckResourceAttrSet("tencentcloud_csip_risk_center.example", "assets.#"),
),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里需要测试下导入和更新场景吧

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当然资源不支持导入和修改

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

仅支持修改任务名称

@SevenEarth SevenEarth added run check run check and removed run check run check labels Mar 1, 2024
@SevenEarth SevenEarth added run check run check and removed run check run check labels Mar 1, 2024
@SevenEarth SevenEarth added run check run check and removed run check run check labels Mar 1, 2024
Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx merged commit 870017f into master Mar 1, 2024
@andrew-tx andrew-tx deleted the feat/csip branch March 1, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run check run check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants