Skip to content

fix/waf #2458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2024
Merged

fix/waf #2458

merged 4 commits into from
Jan 5, 2024

Conversation

SevenEarth
Copy link
Collaborator

fix/waf

@SevenEarth SevenEarth added the run check run check label Jan 4, 2024
@@ -1375,6 +1383,8 @@ func resourceTencentCloudWafSaasDomainUpdate(d *schema.ResourceData, meta interf
tmpStatus := strconv.FormatUint(botStatus, 10)
modifyBotStatusRequest.Status = &tmpStatus
modifyBotStatusRequest.Category = common.StringPtr("bot")
modifyBotStatusRequest.IsVersionFour = common.BoolPtr(true)
modifyBotStatusRequest.BotVersion = common.StringPtr("4.1.0")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥写死版本号呢

Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx merged commit e5ae032 into master Jan 5, 2024
@andrew-tx andrew-tx deleted the fix/waf branch January 5, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run check run check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants