Feat/bi support #2239
Merged
Feat/bi support #2239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitmkn
force-pushed
the
feat/bi-support
branch
from
4db3c20 to
09a1c54
Compare
andrew-tx
reviewed
Oct 23, 2023
| ctx := context.WithValue(context.TODO(), logIdKey, logId) | ||
|
|
||
| paramMap := make(map[string]interface{}) | ||
| if v, _ := d.GetOk("page_no"); v != nil { |
| } | ||
|
|
||
| if v, _ := d.GetOk("all_page"); v != nil { | ||
| paramMap["AllPage"] = helper.Bool(v.(bool)) |
gitmkn
force-pushed
the
feat/bi-support
branch
from
a4de4fb to
402c2e2
Compare
andrew-tx
reviewed
Oct 24, 2023
| ctx := context.WithValue(context.TODO(), logIdKey, logId) | ||
|
|
||
| paramMap := make(map[string]interface{}) | ||
| if v, _ := d.GetOk("project_id"); v != nil { |
| paramMap["ProjectId"] = helper.IntInt64(v.(int)) | ||
| } | ||
|
|
||
| if v, _ := d.GetOk("all_page"); v != nil { |
| Config: testAccBiDatasourceCloud, | ||
| Check: resource.ComposeTestCheckFunc( | ||
| resource.TestCheckResourceAttrSet("tencentcloud_bi_datasource_cloud.datasource_cloud", "id"), | ||
| ), |
There was a problem hiding this comment.
补充下 Import 和 update 的 e2e
There was a problem hiding this comment.
这个查询接口查询不到vip、vport、vpc_id，无法支持import，e2e不可执行，涉及密码问题
| response = bi.NewApplyEmbedIntervalResponse() | ||
| biToken string | ||
| ) | ||
| if v, _ := d.GetOk("project_id"); v != nil { |
| request.ProjectId = helper.IntUint64(v.(int)) | ||
| } | ||
|
|
||
| if v, _ := d.GetOk("page_id"); v != nil { |
| Example Usage | ||
|
|
||
| ```hcl | ||
| resource "tencentcloud_bi_embed_interval" "embed_interval" { |
There was a problem hiding this comment.
这个是一个operation资源吗，名称上好像不太容易区分
There was a problem hiding this comment.
resource_tc_bi_token_extend这个可以吗
There was a problem hiding this comment.
跟下面的那个 operation 对应，这个是不是可以叫 resource_tc_bi_embed_interval_apply
下面那个叫 resource_tc_bi_embed_token_apply
| Example Usage | ||
|
|
||
| ```hcl | ||
| resource "tencentcloud_bi_embed_token" "embed_token" { |
There was a problem hiding this comment.
resource_tc_bi_token_apply可以吗
There was a problem hiding this comment.
resource_tc_bi_token_apply可以吗
嗯，这个看起来比较容易理解些
| response = bi.NewCreateEmbedTokenResponse() | ||
| pageId int | ||
| ) | ||
| if v, _ := d.GetOk("project_id"); v != nil { |
| request.ProjectId = helper.IntUint64(v.(int)) | ||
| } | ||
|
|
||
| if v, _ := d.GetOk("page_id"); v != nil { |
| ), | ||
| }, | ||
| { | ||
| Config: testAccBiProjectUserRole, |
gitmkn
force-pushed
the
feat/bi-support
branch
from
16467c3 to
0d466cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.