Skip to content

feat/waf #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2023
Merged

feat/waf #2234

merged 4 commits into from
Oct 23, 2023

Conversation

SevenEarth
Copy link
Collaborator

feat/waf

@SevenEarth SevenEarth added the run check run check label Oct 23, 2023
@@ -88,6 +102,13 @@ func resourceTencentCloudWafClbInstance() *schema.Resource {
ValidateFunc: validateAllowedIntValue(ELASTIC_MODE),
Description: "Is elastic billing enabled, 1: enable, 0: disable.",
},
"qps_limit": {
Optional: true,
Computed: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里为啥加 Computed 呢

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为这个值 不轮传入还是不传 都有值返回,所以增加computed

Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx merged commit e8530de into master Oct 23, 2023
@andrew-tx andrew-tx deleted the feat/waf branch October 23, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run check run check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants