-
Notifications
You must be signed in to change notification settings - Fork 143
es resource #2228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
es resource #2228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-tx
reviewed
Oct 18, 2023
request.InstanceId = helper.String(instanceId) | ||
} | ||
|
||
if v, _ := d.GetOk("type"); v != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里不需要使用GetOkExist吗
andrew-tx
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andrew-tx
added a commit
that referenced
this pull request
Oct 18, 2023
* feat(dnspod): add datasource * feat(dnspod): add datasource * feat(dnspod): add datasource * feat(dnspod): add datasource * feat(dnspod): data source of domain list * docs(dnspod): add changelog of tencentcloud_dnspod_domain_list * docs(dnspod): dnspod domain list * feat(dnspod): groupid parameter * docs(dnspod): go fmt * docs(dnspod): Add datasource of dnspod domain analytics * docs(dnspod): add changelog of datasource dnspod domain analytics * refact(dnspod): fmt code * feat: update cam resource (#2220) * feat: update cam resource * feat: changelog --------- Co-authored-by: WeiMengXS <[email protected]> * refact(dnspod): refact code dnspod domain analytics * feat/kms (#2222) * feat/kms * feat/kms * feat/cam-role-permission-boundary (#2226) * feat: changelog * feat: changelog --------- Co-authored-by: WeiMengXS <[email protected]> * fix(dnspod): groupid parameter * fix(dnspod): groupid parameter * fix(dnspod): groupid parameter * refact(dnspod): remove parameter tag * Feat/cam account (#2225) * feat: doc * feat: set version config * feat: Cam account * feat: doc * feat: doc * feat: changelog * feat: fix getOkExists --------- Co-authored-by: WeiMengXS <[email protected]> * feat(dnspod): support tags * add tke oidc (#2227) * add tke oidc * add changelog * update * feat(dnspod): support tags * feat: organization (#2229) * feat: quit organization operation * feat: quit organization operation * feat: quit organization operation --------- Co-authored-by: WeiMengXS <[email protected]> * es resource (#2228) * es resource * add changelog * update --------- Co-authored-by: mikatong <[email protected]> * docs(dnspod): Add datasource of dnspod domain analytics * docs(dnspod): add changelog of datasource dnspod domain analytics * refact(dnspod): fmt code * refact(dnspod): refact code dnspod domain analytics * refact(dnspod): remove parameter tag * feat(dnspod): e2e refact * feat(dnspod): code conflict --------- Co-authored-by: Wmxs <[email protected]> Co-authored-by: WeiMengXS <[email protected]> Co-authored-by: SevenEarth <[email protected]> Co-authored-by: hellertang <[email protected]> Co-authored-by: tongyiming <[email protected]> Co-authored-by: mikatong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.