Feat/cm support #2212
Merged
Feat/cm support #2212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitmkn
force-pushed
the
feat/cm-support
branch
from
22d83e3 to
5d5aa5c
Compare
andrew-tx
reviewed
Oct 17, 2023
| paramMap["Module"] = helper.String(v.(string)) | ||
| } | ||
|
|
||
| if v, _ := d.GetOk("start_time"); v != nil { |
| return err | ||
| } | ||
|
|
||
| time.Sleep(3 * time.Second) |
There was a problem hiding this comment.
这里等待3秒时间够吗？如果3秒状态未返回会有问题吗
There was a problem hiding this comment.
我们是不是应该封装一个公共的异步请求的方法呢？
|
|
||
| time.Sleep(3 * time.Second) | ||
| service := MonitorService{client: meta.(*TencentCloudClient).apiV3Conn} | ||
| err = resource.Retry(1*readRetryTimeout, func() *resource.RetryError { |
gitmkn
force-pushed
the
feat/cm-support
branch
from
fc10bfb to
5b31e7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.