add resrouce vpn gateway, customer gateway and vpn connection
#183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Himer
reviewed
Nov 12, 2019
Himer
reviewed
Nov 12, 2019
Himer
reviewed
Nov 12, 2019
Himer
reviewed
Nov 12, 2019
Himer
reviewed
Nov 12, 2019
Himer
reviewed
Nov 12, 2019
Himer
reviewed
Nov 12, 2019
Himer
reviewed
Nov 12, 2019
Himer
reviewed
Nov 12, 2019
Himer
reviewed
Nov 12, 2019
Himer
reviewed
Nov 12, 2019
| if tErr != nil { | ||
| log.Printf("[CRITAL]%s create VPN connection failed, reason:%s\n", logId, tErr.Error()) | ||
| return tErr | ||
| } |
There was a problem hiding this comment.
此处有点问题len(result.Response.VpnConnectionSet) == 0 表示线上不存在了,下面就不用在执行DeleteCustomerGateway,不然服务端会一直报错writeRetryTimeout时间
There was a problem hiding this comment.
这个上面describe的是tunnel不是gateway，删掉了tunnel后再删除gateway
Himer
reviewed
Nov 12, 2019
Himer
reviewed
Nov 12, 2019
| return retryError(e) | ||
| } else { | ||
| if len(result.Response.VpnConnectionSet) == 0 { | ||
| return nil |
There was a problem hiding this comment.
同样 此时 不需要执行下面的DeleteVpnGateway
oliverpei
reviewed
Nov 12, 2019
oliverpei
reviewed
Nov 12, 2019
oliverpei
reviewed
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add resrouce
vpn gateway,customer gatewayandvpn connection