Skip to content

Fix gaap nil error #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 8, 2019
Merged

Fix gaap nil error #159

merged 3 commits into from
Oct 8, 2019

Conversation

Sherlock-Holo
Copy link
Contributor

gaap http_domain some attributes certificate_id, client_certificate_id, realserver_auth, basic_auth and gaap_auth sometimes return null, set them default value when they are null to avoid user can't terraform refresh

@Sherlock-Holo
fix: fix nil error
4e5b638 
when response attributes are nil, don't return an error, set a default
value

Signed-off-by: Sherlock Holo <[email protected]>
@Sherlock-Holo
docs: update changelog
92f1a55 
Signed-off-by: Sherlock Holo <[email protected]>
@ghost ghost added the size/XS label Sep 26, 2019
@Sherlock-Holo
docs: rewrite changlog
3b5dea8 
Signed-off-by: Sherlock Holo <[email protected]>
@ghost ghost added size/S and removed size/XS labels Sep 26, 2019
@oliverpei oliverpei merged commit b401ba0 into tencentcloudstack:master Oct 8, 2019
@Sherlock-Holo Sherlock-Holo deleted the gaap-fix branch December 23, 2019 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likexian likexian likexian approved these changes

@gailwang gailwang gailwang approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sherlock-Holo @likexian @gailwang @oliverpei