This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Fix check for ios simulator #811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 |
TsvetanMilanov
force-pushed
the
milanov/fix-check-for-ios-simulator
branch
from
8d04d28 to
5c810da
Compare
|
❤️ |
rosen-vladimirov
approved these changes
Sep 27, 2016
|
|
||
| function createTestInjector(): IInjector { | ||
| let injector = new Yok(); | ||
| injector.register("childProcess", { | ||
| exec: (command: string) => Future.fromResult(isCurrentlyRunning ? 'launchd_sim' : '') | ||
| exec: (command: string) => Future.fromResult("") |
There was a problem hiding this comment.
I believe you no longer need this mock of childProcess
When we check if there is running simulator we use ps cax but if the simulator is killed for a short period of time after that there is a process listed when using ps cax and we decide that there is a running simulator and then we try to use it but ios-sim-portable returns null. We should check if the simulator returned from ios-sim-portable is not null or undefined in order to continue to work with it.
TsvetanMilanov
force-pushed
the
milanov/fix-check-for-ios-simulator
branch
from
5c810da to
78b3b81
Compare
|
❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we check if there is running simulator we use ps cax but if the simulator is killed for a short period of time after that there is a process listed when using ps cax and we decide that there is a running simulator and then we try to use it but ios-sim-portable returns null. We should check if the simulator returned from ios-sim-portable is not null or undefined in order to continue to work with it.