This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Livesync iOS simulator restart fixes #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ |
|
❤️ |
| filePath: string, | ||
| notRunningiOSSimulatorAction: () => IFuture<void>, | ||
| iOSSimulatorRelativeToProjectBasePathAction:(projectFile: string) => string): void { | ||
| if (this.batch == null || !this.batch.syncPending) { |
There was a problem hiding this comment.
Consider the shorter !this.batch
|
❤️ |
|
👍 |
No longer restarting after every file copy operation and batching file syncs instead.
The `killall` operation wasn't always killing the process by the time we attempted the `xcrun` action. Now we wait for half a second before starting the app.
After code review.
hdeshev
force-pushed
the
livesync-ios-restart
branch
from
83f4705 to
ee89f94
Compare
|
❤️ |
hdeshev
added a commit
that referenced
this pull request
Sep 17, 2015
Livesync iOS simulator restart fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also pulled the batching/timeout code to a
SyncBatchclass, so we can share it with the android batch sync operation. Tested and working on an android emulator as well.