This repository was archived by the owner on Feb 2, 2021. It is now read-only.
fix: fix file not found exception when enumerating a dir with non existing symlinks #1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sting symlinks (avoiding invalid shouldBuild results on iOS)
rosen-vladimirov
approved these changes
Jul 12, 2018
There was a problem hiding this comment.
Nice work. Just to note the solution - when you have a symlink to a file, but the original file does not exist, fs.existsSync API returns false for the symlink itself, even if the linked file is there. You can try this by calling:
$ touch a
$ ln -s a b
$ node -p "fs.existsSync('b')"
true
$ rm a
$ node -p "fs.existsSync('b')"
false
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to issue #3741