Merge pull request #1079 from telerik/vladimirov/clean-deps

fix(deps): Remove dependencies that we do not use

Author: rosen-vladimirov

bootstrap.ts

@@ -28,7 +28,6 @@ $injector.require("childProcess", "./child-process");
 $injector.require("prompter", "./prompter");
 $injector.require("projectHelper", "./project-helper");
 $injector.require("pluginVariablesHelper", "./plugin-variables-helper");
-$injector.require("propertiesParser", "./properties-parser");
 $injector.require("progressIndicator", "./progress-indicator");
 
 $injector.requireCommand(["help", "/?"], "./commands/help");

declarations.d.ts

@@ -658,13 +658,6 @@ interface IProjectHelper extends IProjectDir {
 	sanitizeName(appName: string): string;
 }
 
-interface IPropertiesParser {
-	parse(text: string): any;
-	createEditor(filePath: string): Promise<any>;
-	saveEditor(): Promise<void>;
-	read(filePath: string): Promise<any>;
-}
-
 interface IDictionary<T> {
 	[key: string]: T
 }
@@ -770,11 +763,11 @@ interface IAnalyticsSettingsService {
  	getPlaygroundInfo(projectDir?: string): Promise<IPlaygroundInfo>;
 }
 
-/** 
+/**
  * Designed for getting information for projects that are exported from playground.
  */
 interface IPlaygroundService {
-	/** 
+	/**
 	 * Gets information for projects that are exported from playground
 	 * @return {Promise<IPlaygroundInfo>} collected info
 	 * @param projectDir Project directory path
@@ -785,7 +778,7 @@ interface IPlaygroundService {
  * Describes information about project that is exported from playground.
  */
 interface IPlaygroundInfo {
-	/** 
+	/**
 	 * The unique client identifier
 	 */
 	id: string;
@@ -1347,7 +1340,7 @@ interface IDoctorService {
 	 * @returns {Promise<void>}
 	 */
 	printWarnings(configOptions?: { trackResult: boolean }): Promise<void>;
-	/** 
+	/**
 	 * Runs the setup script on host machine
 	 * @returns {Promise<ISpawnResult>}
 	*/

definitions/bufferpack.d.ts

@@ -5,9 +5,6 @@ import { ReadStream } from "tty";
 import { Configurations } from "./constants";
 import { EventEmitter } from "events";
 import * as crypto from "crypto";
-import progress = require("progress-stream");
-import filesize = require("filesize");
-import * as util from "util";
 
 const Table = require("cli-table");
 
@@ -36,46 +33,48 @@ export function regExpEscape(input: string): string {
 	return input.replace(/[|\\{}()[\]^$+*?.]/g, "\\$&");
 }
 
-export function trackDownloadProgress(destinationStream: NodeJS.WritableStream, url: string): NodeJS.ReadableStream {
-	// \r for carriage return doesn't work on windows in node for some reason so we have to use it's hex representation \x1B[0G
-	let lastMessageSize = 0;
-	const carriageReturn = "\x1B[0G";
-	let timeElapsed = 0;
-
-	const isInteractiveTerminal = isInteractive();
-	const progressStream = progress({ time: 1000 }, (progress: any) => {
-		timeElapsed = progress.runtime;
-
-		if (timeElapsed >= 1) {
-			if (isInteractiveTerminal) {
-				this.$logger.write("%s%s", carriageReturn, Array(lastMessageSize + 1).join(" "));
-
-				const message = util.format("%sDownload progress ... %s | %s | %s/s",
-					carriageReturn,
-					Math.floor(progress.percentage) + "%",
-					filesize(progress.transferred),
-					filesize(progress.speed));
-
-				this.$logger.write(message);
-				lastMessageSize = message.length;
-			}
-		}
-	});
-
-	progressStream.on("finish", () => {
-		if (timeElapsed >= 1) {
-			const msg = `Download of ${url} completed.`;
-			if (isInteractiveTerminal) {
-				this.$logger.out("%s%s%s%s", carriageReturn, Array(lastMessageSize + 1).join(" "), carriageReturn, msg);
-			} else {
-				this.$logger.out(msg);
-			}
-		}
-	});
-
-	progressStream.pipe(destinationStream);
-	return progressStream;
-}
+// This function is a state of Art and that's why it has not been deleted.
+// However, its code uses some dependencies that are not used anywhere else, so the code is commented, as we decided to remove those dependencies.
+// export function trackDownloadProgress(destinationStream: NodeJS.WritableStream, url: string): NodeJS.ReadableStream {
+// 	// \r for carriage return doesn't work on windows in node for some reason so we have to use it's hex representation \x1B[0G
+// 	let lastMessageSize = 0;
+// 	const carriageReturn = "\x1B[0G";
+// 	let timeElapsed = 0;
+
+// 	const isInteractiveTerminal = isInteractive();
+// 	const progressStream = progress({ time: 1000 }, (progress: any) => {
+// 		timeElapsed = progress.runtime;
+
+// 		if (timeElapsed >= 1) {
+// 			if (isInteractiveTerminal) {
+// 				this.$logger.write("%s%s", carriageReturn, Array(lastMessageSize + 1).join(" "));
+
+// 				const message = util.format("%sDownload progress ... %s | %s | %s/s",
+// 					carriageReturn,
+// 					Math.floor(progress.percentage) + "%",
+// 					filesize(progress.transferred),
+// 					filesize(progress.speed));
+
+// 				this.$logger.write(message);
+// 				lastMessageSize = message.length;
+// 			}
+// 		}
+// 	});
+
+// 	progressStream.on("finish", () => {
+// 		if (timeElapsed >= 1) {
+// 			const msg = `Download of ${url} completed.`;
+// 			if (isInteractiveTerminal) {
+// 				this.$logger.out("%s%s%s%s", carriageReturn, Array(lastMessageSize + 1).join(" "), carriageReturn, msg);
+// 			} else {
+// 				this.$logger.out(msg);
+// 			}
+// 		}
+// 	});
+
+// 	progressStream.pipe(destinationStream);
+// 	return progressStream;
+// }
 
 export function isAllowedFinalFile(item: string): RegExpMatchArray {
 	return item.match(/.*\.aar/) ||