fix(deps): Remove filesize and progress-stream

Remove filesize and progress-stream dependencies as they've been used only in a function that is never called.
As the function implements interesting functionality, it is commented, not deleted. However, the dependencies are not used anywhere else, so they can be safely removed.

Author: rosen-vladimirov

definitions/filesize.d.ts

@@ -5,9 +5,6 @@ import { ReadStream } from "tty";
 import { Configurations } from "./constants";
 import { EventEmitter } from "events";
 import * as crypto from "crypto";
-import progress = require("progress-stream");
-import filesize = require("filesize");
-import * as util from "util";
 
 const Table = require("cli-table");
 
@@ -36,46 +33,48 @@ export function regExpEscape(input: string): string {
 	return input.replace(/[|\\{}()[\]^$+*?.]/g, "\\$&");
 }
 
-export function trackDownloadProgress(destinationStream: NodeJS.WritableStream, url: string): NodeJS.ReadableStream {
-	// \r for carriage return doesn't work on windows in node for some reason so we have to use it's hex representation \x1B[0G
-	let lastMessageSize = 0;
-	const carriageReturn = "\x1B[0G";
-	let timeElapsed = 0;
-
-	const isInteractiveTerminal = isInteractive();
-	const progressStream = progress({ time: 1000 }, (progress: any) => {
-		timeElapsed = progress.runtime;
-
-		if (timeElapsed >= 1) {
-			if (isInteractiveTerminal) {
-				this.$logger.write("%s%s", carriageReturn, Array(lastMessageSize + 1).join(" "));
-
-				const message = util.format("%sDownload progress ... %s | %s | %s/s",
-					carriageReturn,
-					Math.floor(progress.percentage) + "%",
-					filesize(progress.transferred),
-					filesize(progress.speed));
-
-				this.$logger.write(message);
-				lastMessageSize = message.length;
-			}
-		}
-	});
-
-	progressStream.on("finish", () => {
-		if (timeElapsed >= 1) {
-			const msg = `Download of ${url} completed.`;
-			if (isInteractiveTerminal) {
-				this.$logger.out("%s%s%s%s", carriageReturn, Array(lastMessageSize + 1).join(" "), carriageReturn, msg);
-			} else {
-				this.$logger.out(msg);
-			}
-		}
-	});
-
-	progressStream.pipe(destinationStream);
-	return progressStream;
-}
+// This function is a state of Art and that's why it has not been deleted.
+// However, its code uses some dependencies that are not used anywhere else, so the code is commented, as we decided to remove those dependencies.
+// export function trackDownloadProgress(destinationStream: NodeJS.WritableStream, url: string): NodeJS.ReadableStream {
+// 	// \r for carriage return doesn't work on windows in node for some reason so we have to use it's hex representation \x1B[0G
+// 	let lastMessageSize = 0;
+// 	const carriageReturn = "\x1B[0G";
+// 	let timeElapsed = 0;
+
+// 	const isInteractiveTerminal = isInteractive();
+// 	const progressStream = progress({ time: 1000 }, (progress: any) => {
+// 		timeElapsed = progress.runtime;
+
+// 		if (timeElapsed >= 1) {
+// 			if (isInteractiveTerminal) {
+// 				this.$logger.write("%s%s", carriageReturn, Array(lastMessageSize + 1).join(" "));
+
+// 				const message = util.format("%sDownload progress ... %s | %s | %s/s",
+// 					carriageReturn,
+// 					Math.floor(progress.percentage) + "%",
+// 					filesize(progress.transferred),
+// 					filesize(progress.speed));
+
+// 				this.$logger.write(message);
+// 				lastMessageSize = message.length;
+// 			}
+// 		}
+// 	});
+
+// 	progressStream.on("finish", () => {
+// 		if (timeElapsed >= 1) {
+// 			const msg = `Download of ${url} completed.`;
+// 			if (isInteractiveTerminal) {
+// 				this.$logger.out("%s%s%s%s", carriageReturn, Array(lastMessageSize + 1).join(" "), carriageReturn, msg);
+// 			} else {
+// 				this.$logger.out(msg);
+// 			}
+// 		}
+// 	});
+
+// 	progressStream.pipe(destinationStream);
+// 	return progressStream;
+// }
 
 export function isAllowedFinalFile(item: string): RegExpMatchArray {
 	return item.match(/.*\.aar/) ||

definitions/progress-stream.d.ts

@@ -32,7 +32,6 @@
     "colors": "0.6.2",
     "cookie": "0.1.0",
     "esprima": "2.7.0",
-    "filesize": "2.0.3",
     "gaze": "1.0.0",
     "iconv-lite": "0.4.3",
     "inquirer": "0.8.2",
@@ -51,7 +50,6 @@
     "osenv": "0.1.0",
     "parse5": "2.2.0",
     "plist": "1.1.0",
-    "progress-stream": "0.5.0",
     "proxy-lib": "0.2.0",
     "pullstream": "https://github.com/icenium/node-pullstream/tarball/master",
     "qr-image": "3.2.0",