Fix signed integer overflow #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#33 is filed regarding CI fails on Linux. |
A cast of the unsigned value 2^32-1 to `int` has implementation defined behavior, see n1256, 6.3.1.3.3). Sketch: ``` lua_pop(L, <uint32_t> 0) --(macro expansion)-- lua_settop(L, (int)<uint32_t> -0-1) --(constant folding)-- lua_settop(L, (int)<uint32_t> 2^32-1) --(UB cast to int)-- lua_settop(L, <int>implementation defined value, usually -1) ``` See all the details in tarantool/tarantool#8453
Totktonada
force-pushed
the
fix-signed-integer-overflow
branch
from
9c160b5 to
925e4c9
Compare
It is solved now. |
Buristan
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cast of the unsigned value 2^32-1 to
inthas implementation defined behavior, see n1256, 6.3.1.3.3).Sketch:
See all the details in tarantool/tarantool#8453