ci: add pure cmake . && make build flow #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
force-pushed
the
Totktonada/add-pure-cmake-and-make-into-ci
branch
2 times, most recently
from
366330a to
eadca28
Compare
Totktonada
added
code health
Totktonada
force-pushed
the
Totktonada/add-pure-cmake-and-make-into-ci
branch
from
eadca28 to
56d5c19
Compare
The new CI rule ensures that a usual developer build flow is working. It also improves testing by using the `Debug` build type, which adds the `-Werror` compiler option. Compiler warnings are interpreted as errors in this case. It is inspired by #24, where the `Debug` build fails, but `RelWithDebInfo` is fine. This commit follows a spirit of [1], where it was declared that we should verify as developer's flow as well as user's flow. We missed developer's flow in CI of this module and now it is here. [1]: tarantool/tarantool#6056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new CI rule ensures that a usual developer build flow is working. It also improves testing by using the
Debugbuild type, which adds the-Werrorcompiler option. Compiler warnings are interpreted as errors in this case.It is inspired by #24, where the
Debugbuild fails, butRelWithDebInfois fine.This commit follows a spirit of tarantool/tarantool#6056, where it was declared that we should verify as developer's flow as well as user's flow. We missed developer's flow in CI of this module and now it is here.