build: fix compilation against tarantool 2.10.3+ #27
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonidVas
approved these changes
Oct 4, 2022
An inclusion of `string.h` header file was removed from `tarantool/module.h` in tarantool 2.10.3, see [1]. This module uses `strstr()`, `strlen()` and `memcpy()` functions defined by `string.h`, so it must include this header. The problem affects the `Debug` build type, which is default for the `cmake . && make` build flow (it is usually used by developers of the module). This build type adds `-Werror` compilation flag. However the problem doesn't affect the `tarantoolctl rocks install tuple-keydef [<version>]` build flow, because it uses the `RelWithDebInfo` build type. All compiler warnings are just warnings here. [1]: tarantool/tarantool#7663 Fixes #24
Totktonada
force-pushed
the
Totktonada/gh-24-add-include-string-h
branch
from
cba1a3b to
ddf1068
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An inclusion of
string.hheader file was removed fromtarantool/module.hin tarantool 2.10.3, see tarantool/tarantool#7663.This module uses
strstr(),strlen()andmemcpy()functions defined bystring.h, so it must include this header.The problem affects the
Debugbuild type, which is default for thecmake . && makebuild flow (it is usually used by developers of the module). This build type adds-Werrorcompilation flag. However the problem doesn't affect thetarantoolctl rocks install tuple-keydef [<version>]build flow, because it uses theRelWithDebInfobuild type. All compiler warnings are just warnings here.Fixes #24