Skip to content

Add tarantool-2.10 into CI #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Totktonada opened this issue Oct 19, 2021 · 0 comments · Fixed by #26
Closed

Add tarantool-2.10 into CI #21

Totktonada opened this issue Oct 19, 2021 · 0 comments · Fixed by #26
Labels
ci Improvements of continuous integration / delivery code health Improve code readability, simplify maintenance and so on

Comments

@Totktonada
Copy link
Member

I guess we should update the version parsing code in a test:

local function parse_tarantool_version(component)
-- _TARANTOOL gives a string of the following kind:
--
-- * '2.8.1-0-ge2a1ec0c2' for opensource tarantool;
-- * '2.8.1-0-ge2a1ec0c2-r405' for tarantool enterprise.
--
-- Nicely, tarantool enterprise reports the opensource
-- version, on which it is based, in the first four components
-- (as well as in the commit hash).
--
-- So we ignore everything after 4th component.
local pattern = '^(%d+).(%d+).(%d+)-(%d+)-g[0-9a-f]+'
return tonumber((select(component, _TARANTOOL:match(pattern))))
end

@Totktonada Totktonada added ci code health Improve code readability, simplify maintenance and so on labels Oct 19, 2021
@TarantoolBot TarantoolBot removed the ci label Jan 27, 2022
Totktonada added a commit that referenced this issue Oct 3, 2022
The test was confused by the entrypoint/alpha/beta/rc suffixes in the
version string (see [1] about those suffixes). Now they're ignored.

It is not perfectly correct (2.10.0-rc1 is less than 2.10.0), but enough
for this test.

[1]: tarantool/tarantool#6182

Part of #21
Totktonada added a commit that referenced this issue Oct 3, 2022
It is easy to do now, when [1] is implemented.

[1]: tarantool/setup-tarantool#19

Fixes #21
@Totktonada Totktonada added the ci Improvements of continuous integration / delivery label Oct 3, 2022
Totktonada added a commit that referenced this issue Oct 3, 2022
The test was confused by the entrypoint/alpha/beta/rc suffixes in the
version string (see [1] about those suffixes). Now they're ignored.

It is not perfectly correct (2.10.0-rc1 is less than 2.10.0), but enough
for this test.

[1]: tarantool/tarantool#6182

Part of #21

(cherry picked from commit 871ba45)
Totktonada added a commit that referenced this issue Oct 3, 2022
It is easy to do now, when [1] is implemented.

[1]: tarantool/setup-tarantool#19

Fixes #21

(cherry picked from commit 171002d)
Totktonada added a commit that referenced this issue Oct 4, 2022
The test was confused by the entrypoint/alpha/beta/rc suffixes in the
version string (see [1] about those suffixes). Now they're ignored.

It is not perfectly correct (2.10.0-rc1 is less than 2.10.0), but enough
for this test.

[1]: tarantool/tarantool#6182

Part of #21
Totktonada added a commit that referenced this issue Oct 4, 2022
It is easy to do now, when [1] is implemented.

[1]: tarantool/setup-tarantool#19

Fixes #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Improvements of continuous integration / delivery code health Improve code readability, simplify maintenance and so on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants