Skip to content

Warning in CMake output #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ligurio opened this issue Sep 29, 2021 · 0 comments · Fixed by #19
Closed

Warning in CMake output #18

ligurio opened this issue Sep 29, 2021 · 0 comments · Fixed by #19
Labels
code health Improve code readability, simplify maintenance and so on

Comments

@ligurio
Copy link
Member

ligurio commented Sep 29, 2021 •
edited
Loading 

sergeyb@pony:~/sources/MRG/tuple-keydef/build$ cmake ..
-- The C compiler identification is GNU 9.3.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
CMake Warning (dev) at /home/sergeyb/.local/lib/python3.8/site-packages/cmake/data/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:273 (message):
  The package name passed to `find_package_handle_standard_args` (TARANTOOL)
  does not match the name of the calling package (Tarantool).  This can lead
  to problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  cmake/FindTarantool.cmake:27 (find_package_handle_standard_args)
  CMakeLists.txt:16 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Found TARANTOOL: /usr/include (found version "2.8.2-16-g88458ba1c") 
-- Tarantool LUADIR is share/tarantool
-- Tarantool LIBDIR is lib/tarantool
-- Configuring done
-- Generating done
-- Build files have been written to: /home/sergeyb/sources/MRG/tuple-keydef/build

Git hash: 109c913
ligurio added a commit that referenced this issue Sep 29, 2021
@ligurio
cmake: fix warning
608786d 
Closes #18
@ligurio ligurio mentioned this issue Sep 29, 2021
Merged
@Totktonada Totktonada added the code health Improve code readability, simplify maintenance and so on label Sep 29, 2021
Totktonada pushed a commit that referenced this issue Sep 29, 2021
@ligurio @Totktonada
cmake: fix warning
f7f84f0 
Closes #18
Totktonada added a commit that referenced this issue Oct 1, 2021
@Totktonada
cmake: fail early if no module.h found
fb18e3e 
Commit f7f84f0 ('cmake: fix warning')
causes a little regression: if there is no tarantool/module.h header, we
should fail at the cmake stage. After the fix of the warning we'll fail
only at the building stage (when `make` is called). Here I return the
old behaviour (fail on the `cmake` stage) back.

Follows up #18
@Totktonada Totktonada mentioned this issue Oct 1, 2021
Merged
Totktonada added a commit that referenced this issue Oct 2, 2021
@Totktonada
cmake: fail early if no module.h found
d86c0a3 
Commit f7f84f0 ('cmake: fix warning')
causes a little regression: if there is no tarantool/module.h header, we
should fail at the cmake stage. After the fix of the warning we'll fail
only at the building stage (when `make` is called). Here I return the
old behaviour (fail on the `cmake` stage) back.

Follows up #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code health Improve code readability, simplify maintenance and so on
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmake: fix warning tarantool/tuple-keydef
2 participants
@Totktonada @ligurio