Skip to content

fix: Misspell in return error code #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

fix: Misspell in return error code #277

wants to merge 0 commits into from

Conversation

bekhzod91
Copy link
Contributor

No description provided.

@bekhzod91 bekhzod91 changed the title fix: Misspell in return code fix: Misspell in return error code Jan 31, 2023
DifferentialOrange
DifferentialOrange reviewed Feb 10, 2023
View reviewed changes
Copy link
Member

@DifferentialOrange DifferentialOrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! Can you add a changelog entry? And, please, use lower case in commit message ("Misspell" to "misspell").

It's a shame that we still haven't got a linter to prevent this, but there are too many things we'll need to rework beforehand.

@DifferentialOrange
Copy link
Member

DifferentialOrange commented Feb 10, 2023 •
edited
Loading

Some of the CI pipelines are red now, but this is definitely on my side.

UPD: please, rebase on master

@bekhzod91 bekhzod91 closed this Feb 10, 2023
@bekhzod91 bekhzod91 mentioned this pull request Feb 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DifferentialOrange DifferentialOrange DifferentialOrange left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bekhzod91 @DifferentialOrange