-
Notifications
You must be signed in to change notification settings - Fork 46
api: any msgpack supported type as a request key #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: any msgpack supported type as a request key #244
Conversation
c3faa88
to
6675bb1
Compare
6675bb1
to
30d8cd3
Compare
Is there a test for this behavior? |
To be honest, I don't think it's worth it because it would be a test for Tarantool only.
This behavior haven't even changed with this patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! LGTM
Inserting a tuple with connector does not have any type restrictions on its contents: any MessagePack supported type is allowed. If there are any type violations on the Tarantool side, server would return the corresponding error. There is no reason to do any explicit type checks for request keys. This patch fixed using extended types as keys. Tarantool 2.10 does not support indexing intervals, so there are no tests for INTERVAL extension type. Closes #240
30d8cd3
to
0011ff6
Compare
In other words, there is no such thing as "unsupported type of a request key". Anything could be a key until it matches space format (and connector does not do any excessive format validations between tuples/keys and spaces). There is such a thing as "unsupported type for a primary index", but it is not related to connector at all. |
I get an idea with an unsupported MessagePack extension ID. Tarantool should return the error in this case. |
Yeah, it should be like this. But it is still not related to this patch. This patch is simply about removing unnecessary type checkup. I think it was here for Tarantool 1.5 |
Inserting a tuple with connector does not have any type restrictions on its contents: any MessagePack supported type is allowed. If there are any type violations on the Tarantool side, server would return the corresponding error. There is no reason to do any explicit type checks for request keys.
This patch fixed using extended types as keys. Tarantool 2.10 does not support indexing intervals, so there are no tests for INTERVAL extension type.
Closes #240