Skip to content

Dependencies update patch #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 19 additions & 40 deletions .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@ jobs:
tarantool:
- '1.10'
- '2.8'
- '2.x-latest'
- '2.10'
python:
- '3.5'
- '3.6'
- '3.7'
- '3.8'
Expand All @@ -53,40 +52,29 @@ jobs:
msgpack-deps: 'msgpack==0.6.2'
- tarantool: '2.8'
python: '3.10'
msgpack-deps: 'msgpack==1.0.0'
msgpack-deps: 'msgpack==1.0.4'

steps:
- name: Clone the connector
uses: actions/checkout@v2

- name: Install tarantool ${{ matrix.tarantool }}
if: matrix.tarantool != '2.x-latest'
uses: tarantool/setup-tarantool@v1
with:
tarantool-version: ${{ matrix.tarantool }}

- name: Install latest tarantool 2.x
if: matrix.tarantool == '2.x-latest'
run: |
curl -L https://tarantool.io/pre-release/2/installer.sh | sudo bash
sudo apt install -y tarantool tarantool-dev

- name: Setup Python for tests
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python }}

- name: Install specific version of msgpack package
if: startsWith(matrix.msgpack-deps, 'msgpack==') == true
run: |
pip install ${{ matrix.msgpack-deps }}

- name: Install specific version of msgpack-python package
# msgpack package is a replacement for deprecated msgpack-python.
# To test compatibility with msgpack-python we must ignore
# requirements.txt install of msgpack package by overwriting it
# with sed.
if: startsWith(matrix.msgpack-deps, 'msgpack-python==') == true
# We want to enforce using modern msgpack since it has
# various vulnerability fixes. But the code is compatible
# with older msgpack versions and msgpack-python package.
# To this test compatibility we must ignore requirements.txt
# install of the newer msgpack package by overwriting it with sed.
if: matrix.msgpack-deps != ''
run: |
pip install ${{ matrix.msgpack-deps }}
sed -i -e "s/^msgpack.*$/${{ matrix.msgpack-deps }}/" requirements.txt
Expand Down Expand Up @@ -122,10 +110,7 @@ jobs:
- '1.10.11-0-gf0b0e7ecf-r470'
- '2.8.3-21-g7d35cd2be-r470'
- '2.10.0-1-gfa775b383-r486-linux-x86_64'
python: ['3.5', '3.6', '3.7', '3.8', '3.9', '3.10']
msgpack-deps:
# latest msgpack will be installed as a part of requirements.txt
- ''
python: ['3.6', '3.7', '3.8', '3.9', '3.10']

steps:
- name: Clone the connector
Expand All @@ -150,21 +135,6 @@ jobs:
with:
python-version: ${{ matrix.python }}

- name: Install specific version of msgpack package
if: startsWith(matrix.msgpack-deps, 'msgpack==') == true
run: |
pip install ${{ matrix.msgpack-deps }}

- name: Install specific version of msgpack-python package
# msgpack package is a replacement for deprecated msgpack-python.
# To test compatibility with msgpack-python we must ignore
# requirements.txt install of msgpack package by overwriting it
# with sed.
if: startsWith(matrix.msgpack-deps, 'msgpack-python==') == true
run: |
pip install ${{ matrix.msgpack-deps }}
sed -i -e "s/^msgpack.*$/${{ matrix.msgpack-deps }}/" requirements.txt

- name: Install package requirements
run: pip install -r requirements.txt

Expand Down Expand Up @@ -196,6 +166,7 @@ jobs:
tarantool:
- '1.10'
- '2.8'
- '2.10.0.g0a5ce0b9c-1'
python:
- '3.10'

Expand All @@ -219,12 +190,20 @@ jobs:
with:
distribution: Ubuntu-20.04

- name: Install tarantool ${{ matrix.tarantool }} for WSL
- name: Install tarantool ${{ matrix.tarantool }} for WSL (2.8 and older)
if: (matrix.tarantool == '1.10') || (matrix.tarantool == '2.8')
shell: wsl-bash_Ubuntu-20.04 {0}
run: |
curl -L https://tarantool.io/installer.sh | VER=${{ matrix.tarantool }} bash -s -- --type "release"
sudo apt install -y tarantool tarantool-dev

- name: Install tarantool ${{ matrix.tarantool }} for WSL (2.10 and newer)
if: (matrix.tarantool != '1.10') && (matrix.tarantool != '2.8')
shell: wsl-bash_Ubuntu-20.04 {0}
run: |
curl -L https://tarantool.io/release/2/installer.sh | bash -s
sudo apt install -y tarantool=${{ matrix.tarantool }} tarantool-dev=${{ matrix.tarantool }}

- name: Setup test tarantool instance
shell: wsl-bash_Ubuntu-20.04 {0}
run: |
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added

### Changed
- Bump msgpack requirement to 1.0.4 (PR #223).
The only reason of this bump is various vulnerability fixes,
msgpack>=0.4.0 and msgpack-python==0.4.0 are still supported.

### Fixed

Expand Down
4 changes: 1 addition & 3 deletions requirements-test.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
dbapi-compliance==1.15.0
# Use this pyyaml version to be compatible with Python34-x64 on Windows.
# See for more details http://help.appveyor.com/discussions/problems/28023.
pyyaml==5.2b1
pyyaml==6.0
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
msgpack>=0.4.0
msgpack>=1.0.4
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def find_version(*file_paths):
cmdclass=cmdclass,
command_options=command_options,
install_requires=[
'msgpack>=0.4.0',
'msgpack>=1.0.4',
],
python_requires='>=3',
)