Make code compatible with Python3 #181

ligurio · 2020-11-25T09:20:57Z

No description provided.

Totktonada · 2020-11-25T09:44:02Z

See CI on the master branch: python 3 is supported and verified. So I don't understand a problem you tries to solve.

Say, unittest.TestCase contains both assertRaisesRegexp() and assertRaisesRegex() on Python 3.7.6. Even if it would not, we don't need a library to make the simple alias. x.items() from Python 2 is the same as list(x.items()) in Python 3, but it does not meant that you need to follow py2to3 everywhere it suggest you to do so. Mostly it is just doesn't necessary and a view on a mapping object is what you need.

Please, pay attention to don't break Python 2 code.

If I'm too early here, I suggest to mark the PR as draft.

ligurio · 2020-11-25T11:38:49Z

See CI on the master branch: python 3 is supported and verified. So I don't understand a problem you tries to solve.

Yep, code is actually already compatible with Python 3. There are only two places required to fix: print calls and exec call. Please review these two patches. CI is green.

Please, pay attention to don't break Python 2 code.

Sure.

doc/conf.py

test/cluster-py/multi.test.py

In a Python 3 'print' becomes a function, see [1]. Patch makes print calls compatible with Python 3. 1. https://docs.python.org/3/whatsnew/3.0.html#print-is-a-function

exec was a statement in Python 2.x [1] and it has been converted to a function in Python 3.x [2], change introduced in version 3.0 [3]. 1. https://docs.python.org/2/reference/simple_stmts.html#exec 2. https://docs.python.org/3/library/functions.html#exec 3. https://docs.python.org/3/whatsnew/3.0.html

Totktonada

LGTM.

Related issues: - Support Python 3 in Tarantool test suite tarantool/tarantool#5538 - Python 3 in tarantool-python tarantool/tarantool-python#181 tarantool/tarantool-python#186 - Use Python 3 in a test infrastructure tarantool/tarantool#5652 Closes #20

Related issues and changes: - Support Python 3 in Tarantool test suite tarantool/tarantool#5538 - Python 3 in tarantool-python tarantool/tarantool-python#181 tarantool/tarantool-python#186 - Use Python 3 in a test infrastructure tarantool/tarantool#5652 Closes #20

ligurio mentioned this pull request Nov 25, 2020

[10sp] Make test (and other python code) Python3 compatible tarantool/test-run#20

Closed

ligurio force-pushed the ligurio/support-python3 branch 2 times, most recently from 81b5fd4 to 46c565b Compare November 25, 2020 10:34

ligurio requested a review from Totktonada November 25, 2020 11:37

Totktonada reviewed Nov 27, 2020

View reviewed changes

doc/conf.py Show resolved Hide resolved

Totktonada reviewed Nov 27, 2020

View reviewed changes

test/cluster-py/multi.test.py Show resolved Hide resolved

ligurio added 2 commits November 27, 2020 08:38

test: make print calls compatible with Python 3.x

cb33676

In a Python 3 'print' becomes a function, see [1]. Patch makes print calls compatible with Python 3. 1. https://docs.python.org/3/whatsnew/3.0.html#print-is-a-function

ligurio force-pushed the ligurio/support-python3 branch from 46c565b to 7a870fa Compare November 27, 2020 08:42

Totktonada approved these changes Dec 1, 2020

View reviewed changes

Totktonada merged commit 37d5f89 into master Dec 1, 2020

Totktonada deleted the ligurio/support-python3 branch December 1, 2020 07:44

ligurio mentioned this pull request Dec 29, 2020

Switch to python 3 by default in a test infrastructure tarantool/tarantool#5652

Closed

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make code compatible with Python3 #181

Make code compatible with Python3 #181

ligurio commented Nov 25, 2020

Totktonada commented Nov 25, 2020

ligurio commented Nov 25, 2020

Totktonada left a comment

Make code compatible with Python3 #181

Make code compatible with Python3 #181

Conversation

ligurio commented Nov 25, 2020

Totktonada commented Nov 25, 2020

ligurio commented Nov 25, 2020

Totktonada left a comment

Choose a reason for hiding this comment